Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19329 to 7.x: [Filebeat][GSuite] Initial implementation of SAML and User Accounts filesets #19726

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Jul 8, 2020

Cherry-pick of PR #19329 to 7.x branch. Original message:

What does this PR do?

This PR adds a GSuite module to filebeat that uses httpjson as input, and creates a SAML and User accounts filesets for it, which consumes events from https://developers.google.com/admin-sdk/reports/v1/appendix/activity/[saml|user-accounts]

Why is it important?

It is the first step to allow users to consume gsuite activity reports. It sets the common pieces for the next filesets and since SAML and User accounts are the simplest ones makes it easy to test and validate the module functionality.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Both GSuite common fields and fileset specific ones are documented
  • Added test files for filesets

Depends on

#19246

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 8, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 8, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19726 updated]

  • Start Time: 2020-07-14T23:03:43.604+0000

  • Duration: 57 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 4224
Skipped 685
Total 4909

@@ -66,6 +66,10 @@ field. You can revert this change by configuring tags for the module and omittin
- Adds check on `<no value>` config option value for the azure input `resource_manager_endpoint`. {pull}18890[18890]
- Okta module now requires objects instead of JSON strings for the `http_headers`, `http_request_body`, `pagination`, `rate_limit`, and `ssl` variables. {pull}18953[18953]
- Adds oauth support for httpjson input. {issue}18415[18415] {pull}18892[18892]
- Adds `split_events_by` option to httpjson input. {pull}19246[19246]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks it it picked up two extra lines.

@andrewkroh
Copy link
Member

@marc-gr
Copy link
Contributor Author

marc-gr commented Jul 14, 2020

#19925 needs to get merged first

…ilesets (elastic#19329)

* GSuite initial implementation of SAML fileset

* Document fields and generate test file

* Add documentation

* Split fields and improve docs

* Add change to CHANGELOG

* Rename config file and clean docs

* Adds user accounts fileset

* Add delegated user to google oauth

* Add types and make changes to common pipeline

* Do not stop input if array key not found

* Fix docs

* Setup for date cursor

* Add beta tag

* CHANGELOG message

* Improve ECS mappings

* Change cateogrization and types of various fields

* Change event.type to start

* Improve doc references

(cherry picked from commit 7abd67d)
@marc-gr marc-gr merged commit d6c9ee2 into elastic:7.x Jul 15, 2020
@marc-gr marc-gr deleted the backport_19329_7.x branch July 15, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants