Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use fixed type of agent #19625

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

kuisathaverat
Copy link
Contributor

What does this PR do?

Change to use Ubuntu agents to build the images.

Why is it important?

The reference repo in the Debian 8 agents is probably broken. Also is better to use only one kind of agent, the label Linux points to several types of Agents (Debian, CentOS, Ubuntu) and versions, so the agent type+version provisioned can be different every time.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@kuisathaverat kuisathaverat added bug ci Team:Automation Label for the Observability productivity team labels Jul 2, 2020
@kuisathaverat kuisathaverat requested review from jsoriano and a team July 2, 2020 17:53
@kuisathaverat kuisathaverat self-assigned this Jul 2, 2020
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 2, 2020
@mdelapenya
Copy link
Contributor

mdelapenya commented Jul 2, 2020

I know there a tons of commands we run on Docker, but I wonder if using Centos is more aligned with the default base image used on releases.

UPDATE: on the other hand, this Ubuntu is used fr the top-level agent. So nevermind

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 2, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19625 updated]

  • Start Time: 2020-07-02T18:26:41.241+0000

  • Duration: 36 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 555
Skipped 128
Total 683

@kuisathaverat kuisathaverat changed the title ci: user fixed type of agent ci: use fixed type of agent Jul 3, 2020
@kuisathaverat kuisathaverat merged commit 3c9219f into elastic:master Jul 3, 2020
v1v added a commit to v1v/beats that referenced this pull request Jul 3, 2020
…ne-beats

* upstream/master: (35 commits)
  [ci] fix env variable name for xpack filebeats (elastic#19617)
  Cache error responses for cloudfoundry apps metadata (elastic#19181)
  ci: user fixed type of agent (elastic#19625)
  Input v2 cursor testing (elastic#19573)
  Update Jenkinsfile to not inspect removed vendor (elastic#19610)
  Fix ordering and duplicate configs on autodiscover (elastic#19317)
  Prepare input/file for changes in the registrar (elastic#19516)
  Cursor input and manager implementation (elastic#19571)
  [Filebeat] Fix tls mapping in suricata module (elastic#19494)
  [Ingest Manager] Make Agent beta and Constraints experimental (elastic#19586)
  Accept prefix as metric_types for stackdriver metricset in GCP (elastic#19345)
  Implement memlog store operations (elastic#19533)
  introduce journalbeat/pkg in order to provide reusable shared code (elastic#19581)
  Add descriptions to HAProxy fields in Metricbeat (elastic#19561)
  ci: apm-server-update trigered only on upstream, comments, and manual triggered (elastic#19590)
  ci: enable upstream triggering on the packaging job (elastic#19589)
  ci: some jjbb improvements (elastic#19588)
  [MetricBeat] set tags correctly if the dimension value is ARN (elastic#19433)
  [Filebeat] Add default_fields: false to fields.yml in aws module (elastic#19568)
  Add publisher implementation for stateful inputs (elastic#19530)
  ...
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
@kuisathaverat kuisathaverat deleted the user-fixed-type branch December 24, 2020 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants