Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-vendor sarama from the current elastic fork #19226

Closed
wants to merge 3 commits into from
Closed

Re-vendor sarama from the current elastic fork #19226

wants to merge 3 commits into from

Conversation

faec
Copy link
Contributor

@faec faec commented Jun 16, 2020 •
edited
Loading

This PR is the result of re-vendoring sarama from the latest commit of the beats-vendored branch of http://github.com/elastic/sarama, which includes the workaround for the outstanding bug in exponential producer backoff. It was produced by:

go mod edit -replace github.com/Shopify/sarama=github.com/elastic/sarama@1a2a3be32d82d75df68d97cd255ebc039d36e88c

mage vendor

make update

targeting the commit:

commit 1a2a3be32d82d75df68d97cd255ebc039d36e88c (HEAD -> beats-vendored, upstream/beats-vendored)
Merge: 355d120 945143a
Author: Fae Charlton <fae.charlton@elastic.co>
Date:   Wed Jun 10 16:19:46 2020 -0400

    Properly report retry counts when refreshing the lead broker

@faec faec added the bug label Jun 16, 2020
@faec faec requested a review from kvch June 16, 2020 20:39
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 16, 2020
@faec faec added the Team:Services (Deprecated) Label for the former Integrations-Services team label Jun 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 16, 2020
urso
urso reviewed Jun 16, 2020
View reviewed changes
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 16, 2020 •
edited
Loading

💔 Build Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19226 updated]

  • Start Time: 2020-06-18T17:13:25.776+0000

  • Duration: 28 min 1 sec

Steps errors

Expand to view the steps failures

  • Name: Make check

    • Description: make check

    • Duration: 16 min 57 sec

    • Start Time: 2020-06-18T17:22:36.784+0000

    • log

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 23 sec

    • Start Time: 2020-06-18T17:38:37.440+0000

    • log

Log output

Expand to view the last 100 lines of log output 

[2020-06-18T17:41:02.507Z] Stage "Kubernetes" skipped due to earlier failure(s)
[2020-06-18T17:41:02.610Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-06-18T17:41:02.612Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-06-18T17:41:02.613Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-06-18T17:41:02.614Z] Stage "Packetbeat" skipped due to earlier failure(s)
[2020-06-18T17:41:02.615Z] Stage "dockerlogbeat" skipped due to earlier failure(s)
[2020-06-18T17:41:02.616Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-06-18T17:41:02.617Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-06-18T17:41:02.618Z] Stage "Journalbeat" skipped due to earlier failure(s)
[2020-06-18T17:41:02.619Z] Stage "Generators" skipped due to earlier failure(s)
[2020-06-18T17:41:03.363Z] Failed in branch Elastic Agent x-pack
[2020-06-18T17:41:03.363Z] Failed in branch Elastic Agent x-pack Windows
[2020-06-18T17:41:03.364Z] Failed in branch Elastic Agent Mac OS X
[2020-06-18T17:41:03.365Z] Failed in branch Filebeat oss
[2020-06-18T17:41:03.366Z] Failed in branch Filebeat x-pack
[2020-06-18T17:41:03.366Z] Failed in branch Filebeat Mac OS X
[2020-06-18T17:41:03.367Z] Failed in branch Filebeat x-pack Mac OS X
[2020-06-18T17:41:03.367Z] Failed in branch Filebeat Windows
[2020-06-18T17:41:03.368Z] Failed in branch Filebeat x-pack Windows
[2020-06-18T17:41:03.369Z] Failed in branch Auditbeat oss Linux
[2020-06-18T17:41:03.369Z] Failed in branch Auditbeat crosscompile
[2020-06-18T17:41:03.370Z] Failed in branch Auditbeat oss Mac OS X
[2020-06-18T17:41:03.370Z] Failed in branch Auditbeat oss Windows
[2020-06-18T17:41:03.371Z] Failed in branch Auditbeat x-pack
[2020-06-18T17:41:03.372Z] Failed in branch Auditbeat x-pack Mac OS X
[2020-06-18T17:41:03.372Z] Failed in branch Auditbeat x-pack Windows
[2020-06-18T17:41:03.373Z] Failed in branch Libbeat x-pack
[2020-06-18T17:41:03.374Z] Failed in branch Metricbeat OSS Unit tests
[2020-06-18T17:41:03.374Z] Failed in branch Metricbeat OSS Integration tests
[2020-06-18T17:41:03.375Z] Failed in branch Metricbeat Python integration tests
[2020-06-18T17:41:03.375Z] Failed in branch Metricbeat crosscompile
[2020-06-18T17:41:03.376Z] Failed in branch Metricbeat Mac OS X
[2020-06-18T17:41:03.377Z] Failed in branch Metricbeat x-pack Mac OS X
[2020-06-18T17:41:03.377Z] Failed in branch Metricbeat Windows
[2020-06-18T17:41:03.378Z] Failed in branch Metricbeat x-pack Windows
[2020-06-18T17:41:03.378Z] Failed in branch Winlogbeat Windows x-pack
[2020-06-18T17:41:03.379Z] Failed in branch Kubernetes
[2020-06-18T17:41:03.702Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-06-18T17:41:03.704Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-06-18T17:41:03.705Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-06-18T17:41:03.706Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-06-18T17:41:03.707Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-06-18T17:41:03.708Z] Stage "Generators" skipped due to earlier failure(s)
[2020-06-18T17:41:03.788Z] Failed in branch Packetbeat
[2020-06-18T17:41:03.789Z] Failed in branch dockerlogbeat
[2020-06-18T17:41:03.790Z] Failed in branch Journalbeat
[2020-06-18T17:41:04.040Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-06-18T17:41:04.041Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-06-18T17:41:04.043Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-06-18T17:41:04.044Z] Stage "Generators" skipped due to earlier failure(s)
[2020-06-18T17:41:04.088Z] Failed in branch Metricbeat x-pack
[2020-06-18T17:41:04.089Z] Failed in branch Winlogbeat
[2020-06-18T17:41:04.317Z] Failed in branch Heartbeat
[2020-06-18T17:41:04.318Z] Failed in branch Libbeat
[2020-06-18T17:41:04.319Z] Failed in branch Functionbeat
[2020-06-18T17:41:04.320Z] Stage "Generators" skipped due to earlier failure(s)
[2020-06-18T17:41:04.423Z] Failed in branch Generators
[2020-06-18T17:41:04.577Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19226/src/github.com/elastic/beats
[2020-06-18T17:41:04.889Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-06-18T17:41:04.903Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19226/src/github.com/elastic/beats/Lint
[2020-06-18T17:41:05.281Z] + cat
[2020-06-18T17:41:05.281Z] + /usr/local/bin/runbld ./runbld-script
[2020-06-18T17:41:05.281Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-06-18T17:41:11.951Z] runbld>>> runbld started
[2020-06-18T17:41:11.951Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-06-18T17:41:13.346Z] runbld>>> The following profiles matched the job 'Beats/beats-beats-mbp/PR-19226' in order of occurrence in the config (last value wins).
[2020-06-18T17:41:14.728Z] runbld>>> Debug logging enabled.
[2020-06-18T17:41:14.728Z] runbld>>> Storing result
[2020-06-18T17:41:14.991Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-06-18T17:41:14.991Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200618174114-252B5E38
[2020-06-18T17:41:14.991Z] runbld>>> Adding system facts.
[2020-06-18T17:41:15.936Z] runbld>>> Adding vcs info for the latest commit:  ce38533f5d9ff546ff0088402b829b61eb30e670
[2020-06-18T17:41:15.936Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-06-18T17:41:15.936Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-06-18T17:41:15.936Z] + echo 'Processing JUnit reports with runbld...'
[2020-06-18T17:41:15.936Z] Processing JUnit reports with runbld...
[2020-06-18T17:41:16.200Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-06-18T17:41:16.200Z] runbld>>> DURATION: 16ms
[2020-06-18T17:41:16.200Z] runbld>>> STDOUT: 40 bytes
[2020-06-18T17:41:16.200Z] runbld>>> STDERR: 49 bytes
[2020-06-18T17:41:16.200Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-06-18T17:41:16.200Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19226/src/github.com/elastic/beats
[2020-06-18T17:41:17.581Z] runbld>>> Storing build metadata: 
[2020-06-18T17:41:17.581Z] runbld>>> Adding test report.
[2020-06-18T17:41:17.581Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19226/src/github.com/elastic/beats
[2020-06-18T17:41:18.964Z] runbld>>> Found 0 test output files
[2020-06-18T17:41:18.964Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 0 Skipped: 0
[2020-06-18T17:41:18.964Z] runbld>>> Storing result
[2020-06-18T17:41:19.225Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-06-18T17:41:19.225Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200618174114-252B5E38
[2020-06-18T17:41:19.488Z] runbld>>> Email notification disabled by environment variable.
[2020-06-18T17:41:19.488Z] runbld>>> Slack notification disabled by environment variable.
[2020-06-18T17:41:25.735Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19226
[2020-06-18T17:41:26.067Z] [INFO] getVaultSecret: Getting secrets
[2020-06-18T17:41:26.186Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-06-18T17:41:27.334Z] + chmod 755 generate-build-data.sh
[2020-06-18T17:41:27.334Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19226/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19226/runs/3 FAILURE 1681271
[2020-06-18T17:41:27.334Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19226/runs/3/steps/?limit=10000 -o steps-info.json
[2020-06-18T17:41:28.245Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19226/runs/3/tests/?status=FAILED -o tests-errors.json
[2020-06-18T17:41:28.245Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19226/runs/3/log/ -o pipeline-log.txt

@faec
Copy link
Contributor Author

faec commented Jun 18, 2020

This should be fixed now -- the problem was copying the wrong commit hash for the initial command 😅

@urso
Copy link

urso commented Jun 24, 2020

Can you rebase and check the CI output please?

@faec
Copy link
Contributor Author

faec commented Jun 29, 2020

closing this because we've moved to a different target sarama version and new PR process

@faec faec closed this Jun 29, 2020
@faec faec deleted the sarama-fork branch June 29, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urso urso

@kvch kvch

Assignees
No one assigned
Labels
bug Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@faec @elasticmachine @urso @andresrc