Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.8] Encode API key as base64 in common code (#18945) #19065

Merged
merged 1 commit into from
Jun 23, 2020
Merged

[7.8] Encode API key as base64 in common code (#18945) #19065

merged 1 commit into from
Jun 23, 2020

Conversation

ycombinator
Copy link
Contributor

Backports the following commits to 7.8:

@ycombinator ycombinator added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Jun 9, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 9, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 9, 2020 •
edited
Loading

💔 Build Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19065 updated]

  • Start Time: 2020-06-19T13:01:33.433+0000

  • Duration: 74 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 9153
Skipped 1576
Total 10729

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-06-19T13:37:43.665+0000

    • log

  • Name: Make -C libbeat testsuite

    • Description: make -C libbeat testsuite

    • Duration: 8 min 56 sec

    • Start Time: 2020-06-19T13:23:57.701+0000

    • log

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Duration: 2 min 22 sec

    • Start Time: 2020-06-19T14:12:13.088+0000

    • log

Log output

Expand to view the last 100 lines of log output 

[2020-06-19T14:14:35.757Z] + FILE=packetbeat/build/coverage/full.cov
[2020-06-19T14:14:35.757Z] + [ -f packetbeat/build/coverage/full.cov ]
[2020-06-19T14:14:35.757Z] + FILE=winlogbeat/build/coverage/full.cov
[2020-06-19T14:14:35.757Z] + [ -f winlogbeat/build/coverage/full.cov ]
[2020-06-19T14:14:35.757Z] + FILE=journalbeat/build/coverage/full.cov
[2020-06-19T14:14:35.757Z] + [ -f journalbeat/build/coverage/full.cov ]
[2020-06-19T14:14:37.093Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats
[2020-06-19T14:14:37.405Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-06-19T14:14:37.419Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Lint
[2020-06-19T14:14:37.510Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Elastic-Agent-Mac-OS-X
[2020-06-19T14:14:37.591Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Elastic-Agent-x-pack
[2020-06-19T14:14:37.669Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Auditbeat-crosscompile
[2020-06-19T14:14:37.744Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Auditbeat-oss-Mac-OS-X
[2020-06-19T14:14:37.819Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Auditbeat-x-pack-Mac-OS-X
[2020-06-19T14:14:37.897Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Winlogbeat-oss
[2020-06-19T14:14:37.977Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Filebeat-x-pack-Mac-OS-X
[2020-06-19T14:14:38.062Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Dockerlogbeat
[2020-06-19T14:14:38.138Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Journalbeat-oss
[2020-06-19T14:14:38.218Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Metricbeat-Mac-OS-X
[2020-06-19T14:14:38.306Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Functionbeat-x-pack
[2020-06-19T14:14:38.381Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Generators-Metricbeat-Linux
[2020-06-19T14:14:38.456Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Libbeat-oss
[2020-06-19T14:14:38.531Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Metricbeat-crosscompile
[2020-06-19T14:14:38.609Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Elastic-Agent-x-pack-Windows
[2020-06-19T14:14:38.686Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Metricbeat-OSS-Unit-tests
[2020-06-19T14:14:38.763Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Heartbeat-oss
[2020-06-19T14:14:38.840Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Auditbeat-x-pack
[2020-06-19T14:14:38.919Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Libbeat-x-pack
[2020-06-19T14:14:38.997Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Filebeat-Mac-OS-X
[2020-06-19T14:14:39.076Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Auditbeat-oss-Linux
[2020-06-19T14:14:39.153Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Auditbeat-oss-Windows
[2020-06-19T14:14:39.229Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Heartbeat-Mac-OS-X
[2020-06-19T14:14:39.305Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Functionbeat-Mac-OS-X-x-pack
[2020-06-19T14:14:39.382Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Winlogbeat-Windows-x-pack
[2020-06-19T14:14:39.458Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Auditbeat-x-pack-Windows
[2020-06-19T14:14:39.533Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Packetbeat-oss
[2020-06-19T14:14:39.610Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Filebeat-x-pack-Windows
[2020-06-19T14:14:39.687Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Filebeat-Windows
[2020-06-19T14:14:39.766Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Filebeat-x-pack
[2020-06-19T14:14:39.842Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Winlogbeat-Windows
[2020-06-19T14:14:39.920Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Metricbeat-Windows
[2020-06-19T14:14:39.999Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Metricbeat-x-pack-Windows
[2020-06-19T14:14:40.077Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Generators-Beat-Linux
[2020-06-19T14:14:40.152Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Filebeat-oss
[2020-06-19T14:14:40.227Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Heartbeat-Windows
[2020-06-19T14:14:40.302Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Metricbeat-Python-integration-tests
[2020-06-19T14:14:40.392Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Functionbeat-Windows
[2020-06-19T14:14:40.468Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Metricbeat-x-pack-Mac-OS-X
[2020-06-19T14:14:40.543Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Generators-Metricbeat-Mac-OS-X
[2020-06-19T14:14:40.620Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Generators-Beat-Mac-OS-X
[2020-06-19T14:14:40.695Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Metricbeat-x-pack
[2020-06-19T14:14:40.783Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests
[2020-06-19T14:14:41.172Z] + cat
[2020-06-19T14:14:41.172Z] + /usr/local/bin/runbld ./runbld-script
[2020-06-19T14:14:41.172Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-06-19T14:14:47.774Z] runbld>>> runbld started
[2020-06-19T14:14:47.774Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-06-19T14:14:49.687Z] runbld>>> The following profiles matched the job 'Beats/beats-beats-mbp/PR-19065' in order of occurrence in the config (last value wins).
[2020-06-19T14:14:50.629Z] runbld>>> Debug logging enabled.
[2020-06-19T14:14:50.629Z] runbld>>> Storing result
[2020-06-19T14:14:50.889Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-06-19T14:14:50.889Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200619141450-58455D85
[2020-06-19T14:14:50.889Z] runbld>>> Adding system facts.
[2020-06-19T14:14:51.829Z] runbld>>> Adding vcs info for the latest commit:  67e4bf4c2f6c469083cb05a7ec5303b20fc966fb
[2020-06-19T14:14:51.829Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-06-19T14:14:52.090Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-06-19T14:14:52.090Z] Processing JUnit reports with runbld...
[2020-06-19T14:14:52.090Z] + echo 'Processing JUnit reports with runbld...'
[2020-06-19T14:14:52.349Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-06-19T14:14:52.350Z] runbld>>> DURATION: 28ms
[2020-06-19T14:14:52.350Z] runbld>>> STDOUT: 40 bytes
[2020-06-19T14:14:52.350Z] runbld>>> STDERR: 49 bytes
[2020-06-19T14:14:52.350Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-06-19T14:14:52.350Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats
[2020-06-19T14:14:54.260Z] runbld>>> Storing build metadata: 
[2020-06-19T14:14:54.260Z] runbld>>> Adding test report.
[2020-06-19T14:14:54.260Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats
[2020-06-19T14:14:55.641Z] runbld>>> Found 114 test output files
[2020-06-19T14:14:56.584Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-tomcat.xml
[2020-06-19T14:14:56.584Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-istio.xml
[2020-06-19T14:14:56.584Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-openmetrics.xml
[2020-06-19T14:14:56.584Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-cloudfoundry.xml
[2020-06-19T14:14:56.584Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-activemq.xml
[2020-06-19T14:14:56.584Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Metricbeat-x-pack/x-pack/metricbeat/build/TEST-go-integration-iis.xml
[2020-06-19T14:14:57.536Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests/metricbeat/build/TEST-go-integration-windows.xml
[2020-06-19T14:14:57.536Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests/metricbeat/build/TEST-go-integration-graphite.xml
[2020-06-19T14:14:57.796Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 10579 Skipped: 1339
[2020-06-19T14:14:58.056Z] runbld>>> Storing result
[2020-06-19T14:14:58.056Z] runbld>>> FAILURES: 0
[2020-06-19T14:14:58.056Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-06-19T14:14:58.056Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200619141450-58455D85
[2020-06-19T14:14:58.316Z] runbld>>> Email notification disabled by environment variable.
[2020-06-19T14:14:58.316Z] runbld>>> Slack notification disabled by environment variable.
[2020-06-19T14:15:04.350Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-19065
[2020-06-19T14:15:04.595Z] [INFO] getVaultSecret: Getting secrets
[2020-06-19T14:15:04.647Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-06-19T14:15:05.371Z] + chmod 755 generate-build-data.sh
[2020-06-19T14:15:05.371Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19065/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19065/runs/4 FAILURE 4411673
[2020-06-19T14:15:05.371Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19065/runs/4/steps/?limit=10000 -o steps-info.json
[2020-06-19T14:15:07.233Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-19065/runs/4/tests/?status=FAILED -o tests-errors.json

@ycombinator
Encode API key as base64 in common code (elastic#18945)
67e4bf4 
* Encode API key as base64 in common code

* Adding comment on API key field

* Adding CHANGELOG entries

* Adding test

* Base64-encode API key in constructor

* Move encodedAPIKey field to Connection

* Update doc on `api_key` setting value

* Adding API key format to setting section

* Compute entire API key auth header value up front
@ycombinator
Copy link
Contributor Author

Jenkins CI failures are unrelated. Merging.

@ycombinator ycombinator merged commit f90f09f into elastic:7.8 Jun 23, 2020
@ycombinator ycombinator deleted the backport/7.8/pr-18945 branch June 23, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees
No one assigned
Labels
backport Team:Platforms Label for the Integrations - Platforms team [zube]: Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ycombinator @elasticmachine @ChrsMark