Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Fix improper nesting of session_issuer in aws/cloudtrail #18915

Merged
merged 2 commits into from
Jun 5, 2020

Conversation

leehinman
Copy link
Contributor

What does this PR do?

session issuer object is now correctly inside session context object

Why is it important?

Data in session issuer object wasn't being mapped

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TESTING_FILEBEAT_MODULES=aws TESTING_FILEBEAT_FILESETS=cloudtrail mage -v pythonIntegTest

Related issues

@leehinman leehinman added bug Filebeat Filebeat needs_backport PR is waiting to be backported to other branches. Team:SIEM labels Jun 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 2, 2020
pipeline & fields.yml had session issuer outside of the
session context object.  session issuer only appears inside
the session context object.  Not a breaking change because prior to
this the data was being skipped.

Closes elastic#18894
@leehinman leehinman force-pushed the 18894_cloudtrail_session_issuer branch from b878044 to e71832b Compare June 2, 2020 19:37
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 2, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #18915 updated]

  • Start Time: 2020-06-02T19:37:37.923+0000

  • Duration: 52 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 3807
Skipped 672
Total 4479

@leehinman leehinman merged commit 632c086 into elastic:master Jun 5, 2020
@leehinman leehinman deleted the 18894_cloudtrail_session_issuer branch June 5, 2020 22:37
@leehinman leehinman added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jun 5, 2020
leehinman added a commit to leehinman/beats that referenced this pull request Jun 5, 2020
pipeline & fields.yml had session issuer outside of the
session context object.  session issuer only appears inside
the session context object.  Not a breaking change because prior to
this the data was being skipped.

Closes elastic#18894

(cherry picked from commit 632c086)
leehinman added a commit that referenced this pull request Jun 16, 2020
…9022)

pipeline & fields.yml had session issuer outside of the
session context object.  session issuer only appears inside
the session context object.  Not a breaking change because prior to
this the data was being skipped.

Closes #18894

(cherry picked from commit 632c086)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
pipeline & fields.yml had session issuer outside of the
session context object.  session issuer only appears inside
the session context object.  Not a breaking change because prior to
this the data was being skipped.

Closes elastic#18894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Filebeat] Missing sessionContext in cloudtrail fields
3 participants