Add TLS dialer to Kerberos transport as well #18607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kvch
commented
May 18, 2020
•
kvch
commented
- add changelog entry
kvch
added
[zube]: In Review
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
added
needs_team
ycombinator
reviewed
May 18, 2020
| }), | ||
| Timeout: s.Timeout, | ||
| Transport: transp, | ||
| Timeout: s.Timeout, | ||
| } | ||
|
|
||
| if s.Kerberos.IsEnabled() { | ||
| c := &http.Client{ |
There was a problem hiding this comment.
I think we can now remove this statement and use httpClient instead of c as the 2nd argument to kerberos.NewClient below now?
There was a problem hiding this comment.
No, we cannot. kerberos.NewClient expects an http.Client, but the client above is an esHTTPClient.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
zube
bot
added
[zube]: Done
needs_backport
1 task
kvch
added
v7.9.0
and removed
needs_backport
kvch
added a commit
to kvch/beats
that referenced
this pull request
May 19, 2020
(cherry picked from commit 8b17f5a)
1 task
kvch
added a commit
that referenced
this pull request
May 21, 2020
kvch
added a commit
to kvch/beats
that referenced
this pull request
May 21, 2020
(cherry picked from commit 8b17f5a)
kvch
added a commit
that referenced
this pull request
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.