-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version when bulk param is available in ES stats API #18459
Update version when bulk param is available in ES stats API #18459
Conversation
Pinging @elastic/integrations-services (Team:Services) |
Pinging @elastic/stack-monitoring (Stack monitoring) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build SucceededExpand to view the summary
Build stats
Test stats 🧪
|
run tests |
What does this PR do?
Updates the minimum version of Elasticsearch that allows the
GET _stats
API to accept thebulk
parameter.Why is it important?
Elasticsearch added the new
bulk
parameter to theGET _stats
API in elastic/elasticsearch#52208. That PR has been merged so this parameter is available inmaster
/8.0.0
of Elasticsearch. However, that PR has not yet been backported (see elastic/elasticsearch#55447), so this parameter is not available in earlier versions of Elasticsearch yet.So for now we tell the
elasticsearch
Metricbeat module to only add thebulk
parameter to theGET _stats
API call request if the version of Elasticsearch it's talking to is 8.0.0 or higher.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksParity tests should start passing once this PR is merged.I have added an entry inThe feature that introduced this bug will be released in 7.8.0. Since that hasn't yet been released yet, no CHANGELOG entry for the bugfix is necessary.CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.