Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18149 to 7.7: Fix broken x-pack/filebeat tests #18211

Merged
merged 1 commit into from
May 12, 2020

Conversation

andrewkroh
Copy link
Member

Cherry-pick of PR #18149 to 7.7 branch. Original message:

What does this PR do?

The tests are failing due to the change in #16784. The fields key is referenced in
system tests so it needs to be present. This adds the key back.

Why is it important?

master is broken so no new work can be merged.

The tests are failing due to the change in elastic#16784. The `fields` key is referenced in
system tests so it needs to be present.

(cherry picked from commit 3024b66)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 4, 2020
@andrewkroh
Copy link
Member Author

We really should not be changing anything in the 7.7 branch while the 7.7.0 release is pending unless it is a fix for a "blocker". But this change is necessary to fix tests broken by a change that was already merged into 7.7.

@andrewkroh andrewkroh added Team:Integrations Label for the Integrations team and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport LGTM.

@andrewkroh andrewkroh merged commit ecb2260 into elastic:7.7 May 12, 2020
@andrewkroh andrewkroh deleted the backport_18149_7.7 branch January 14, 2022 14:06
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
The tests are failing due to the change in elastic#16784. The `fields` key is referenced in
system tests so it needs to be present.

(cherry picked from commit c7eff6c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants