Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #17823 to 7.x: Add process.command_line to Sysmon module #18181

Merged
merged 1 commit into from
May 4, 2020

Conversation

andrewkroh
Copy link
Member

Cherry-pick of PR #17823 to 7.x branch. Original message:

What does this PR do?

This is a continuation of #17327. The source fork no longer exists.

This add process.command_line and process.parent.command_line to Sysmon Event ID 1.

Why is it important?

The command_line is an ECS field.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

* Add process.command_line to Sysmon module

Adds the process.command_line field to Sysmon module that does not split the field into multiple values.

* Handle process.parent.command_line

Handle the parent process.
Update golden files

Co-authored-by: webhead404 <kvvincentvalentine@gmail.com>
(cherry picked from commit 6473a6e)
@andrewkroh andrewkroh requested a review from a team as a code owner May 4, 2020 16:12
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@andrewkroh andrewkroh removed the needs_team Indicates that the issue/PR needs a Team:* label label May 4, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 79
Skipped 0
Total 79

@andrewkroh andrewkroh merged commit 9b4da43 into elastic:7.x May 4, 2020
@andrewkroh andrewkroh deleted the backport_17823_7.x branch January 14, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants