Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #17569 to 7.7: [Auditbeat][System] Fix error handling around go-sysinfo.Host #17603

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Apr 8, 2020

Cherry-pick of PR #17569 to 7.7 branch. Original message:

Before a system dataset is loaded, host information is loaded to populate entity_id fields.

Error handling around it was incorrect and resulted in a panic when fetching host info failed, which afaik it's limited to errors accessing /proc/stat file.

…c#17569)

Before a system dataset is loaded, host information is loaded to
populate `entity_id` fields.

Error handling around it was incorrect and resulted in a panic when
fetching host info failed, which afaik it's limited to errors accessing
/proc/stat file.

(cherry picked from commit 97750c8)
@adriansr adriansr requested a review from a team as a code owner April 8, 2020 08:58
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport LGTM.

@adriansr adriansr merged commit 4fb9fad into elastic:7.7 Apr 9, 2020
@adriansr adriansr deleted the backport_17569_7.7 branch April 10, 2020 14:32
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…c#17569) (elastic#17603)

Before a system dataset is loaded, host information is loaded to
populate `entity_id` fields.

Error handling around it was incorrect and resulted in a panic when
fetching host info failed, which afaik it's limited to errors accessing
/proc/stat file.

(cherry picked from commit 7602e79)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants