Cherry-pick #17291 to 7.x: Set accept header for prometheus client scraping #17325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set accept header for prometheus to match the same as prometheus upstream. * Fix go.mod. * Add changelog entry. (cherry picked from commit 268511d)
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
ChrsMark
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #17291 to 7.x branch. Original message:
What does this PR do?
Sets the default
Acceptheader for the prometheus scraper to match the same accept header used by upstream prometheus.Why is it important?
Some servers that expose prometheus metrics can fail to respond unless this Accept header is present and correct.
Example being the referenced but that returns HTTP error code 406.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
Acceptheader is sent on request.Related issues