Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Metricbeat azure module to GA and add final tests #17319

Merged
merged 4 commits into from
Mar 31, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Mar 30, 2020

What does this PR do?

Why is it important?

Move the azure module to GA

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@narph narph self-assigned this Mar 30, 2020
@narph narph added [zube]: In Review Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team v7.7.0 labels Mar 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@narph narph requested a review from exekias March 30, 2020 12:10
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, but it's not testing the fields that come out of the different metricsets

I think it's ok for the lightweight metricsets as you only need to test that in monitor, but the rest need some more checks

@narph
Copy link
Contributor Author

narph commented Mar 30, 2020

@exekias , regarding:

I think it's ok for the lightweight metricsets as you only need to test that in monitor, but the rest need some more checks

The field mapping for the other native metricsets looks like this (ex.):

- name: compute_vm.*.*
  release: beta
  type: object
  object_type: float
  object_type_mapping_type: "*"
  description: >
    compute_vm

No other fields but the ones the dynamic mapping covers.
We also cannot predict that all the metricnames will be mapped in one event since we are making separate calls to the azure rest api depending on the timegrain, supported aggregation, namespace etc. and events will have different metrics based on those filters.

Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed on keep adding tests here: #17315

@narph narph merged commit 2bb6fc9 into elastic:master Mar 31, 2020
@narph narph deleted the azure-ga branch March 31, 2020 08:40
narph added a commit to narph/beats that referenced this pull request Mar 31, 2020
* temp

* add tests and move to GA

* changelog

* fix

(cherry picked from commit 2bb6fc9)
narph added a commit to narph/beats that referenced this pull request Mar 31, 2020
* temp

* add tests and move to GA

* changelog

* fix

(cherry picked from commit 2bb6fc9)
narph added a commit that referenced this pull request Mar 31, 2020
… final tests (#17352)

* Move Metricbeat azure module to GA and add final tests (#17319)

* temp

* add tests and move to GA

* changelog

* fix

(cherry picked from commit 2bb6fc9)

* fix changelog
narph added a commit that referenced this pull request Mar 31, 2020
… final tests (#17353)

* Move Metricbeat azure module to GA and add final tests (#17319)

* temp

* add tests and move to GA

* changelog

* fix

(cherry picked from commit 2bb6fc9)

* fix changelog
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…and add final tests (elastic#17352)

* Move Metricbeat azure module to GA and add final tests (elastic#17319)

* temp

* add tests and move to GA

* changelog

* fix

(cherry picked from commit e1114f1)

* fix changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move metricbeat azure module to GA
4 participants