[Filebeat] Improve AWS cloudtrail field mappings #17155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leehinman
added
enhancement
Filebeat
|
Pinging @elastic/siem (Team:SIEM) |
- sessionIssuer.type -> aws.cloudtrail.user_identity.session_issuer.type - sessionIssuer.principalId -> aws.cloudtrail.user_identity.session_issuer.principal_id - sessionIssuer.userName -> user.name - sessionIssuer.arn -> aws.cloudtrail.user_identity.session_issuer.arn - sessionIssuer.accountId -> aws.cloudtrail.user_identity.session_issuer.account_id - add aws.cloudtrail.console_login.additional_eventdata.mobile_version - add aws.cloudtrail.console_login.additional_eventdata.login_to - add aws.cloudtrail.console_login.additional_eventdata.mfa_used - copy source.address to source.ip if value is an IP address Closes elastic#16086 Closes elastic#16110
leehinman
force-pushed
the
16086_16110_cloudtrail
branch
from
275cd7d
to
700b457
Compare
adriansr
approved these changes
Mar 23, 2020
| ignore_failure: true | ||
| - rename: | ||
| field: "json.userIdentity.sessionIssuer.userName" | ||
| target_field: "user.name" |
There was a problem hiding this comment.
Is there a chance this overwrites user.name already set from userIdentity.userName earlier in the pipeline? Is this what we want?
There was a problem hiding this comment.
I was worried about that too, I'll add a comment. sessionIssuer.userName should only be set when there is an assumed role.
4 tasks
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Mar 23, 2020
* Improve AWS cloudtrail field mappings - sessionIssuer.type -> aws.cloudtrail.user_identity.session_issuer.type - sessionIssuer.principalId -> aws.cloudtrail.user_identity.session_issuer.principal_id - sessionIssuer.userName -> user.name - sessionIssuer.arn -> aws.cloudtrail.user_identity.session_issuer.arn - sessionIssuer.accountId -> aws.cloudtrail.user_identity.session_issuer.account_id - add aws.cloudtrail.console_login.additional_eventdata.mobile_version - add aws.cloudtrail.console_login.additional_eventdata.login_to - add aws.cloudtrail.console_login.additional_eventdata.mfa_used - copy source.address to source.ip if value is an IP address Closes elastic#16086 Closes elastic#16110 (cherry picked from commit 57e194b)
leehinman
added
v7.7.0
and removed
needs_backport
leehinman
added a commit
that referenced
this pull request
Mar 23, 2020
* Improve AWS cloudtrail field mappings - sessionIssuer.type -> aws.cloudtrail.user_identity.session_issuer.type - sessionIssuer.principalId -> aws.cloudtrail.user_identity.session_issuer.principal_id - sessionIssuer.userName -> user.name - sessionIssuer.arn -> aws.cloudtrail.user_identity.session_issuer.arn - sessionIssuer.accountId -> aws.cloudtrail.user_identity.session_issuer.account_id - add aws.cloudtrail.console_login.additional_eventdata.mobile_version - add aws.cloudtrail.console_login.additional_eventdata.login_to - add aws.cloudtrail.console_login.additional_eventdata.mfa_used - copy source.address to source.ip if value is an IP address Closes #16086 Closes #16110 (cherry picked from commit 57e194b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16086
Closes #16110
What does this PR do?
Why is it important?
Checklist
- [] I have made corresponding change to the default configuration files