Cherry-pick #17015 to 7.x: Use max in k8s overview dashboard aggregations #17052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not be using a sum on kubernetes.pod.network.rx.bytes, kubernetes.pod.network.tx.bytes, and kubernetes.container.cpu.usage.core.ns; these fields are counters. (cherry picked from commit 0a2b3f4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #17015 to 7.x branch. Original message:
What does this PR do?
Changes types of aggregations from
sumtomaxon the following visualisations of Kubernetes Overview:Why is it important?
We should not be using a sum on kubernetes.pod.network.rx.bytes,
kubernetes.pod.network.tx.bytes, and kubernetes.container.cpu.usage.core.ns;
these fields are counters.
https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/stats/v1alpha1/types.go#L165
https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/stats/v1alpha1/types.go#L198
We should use
maxinstead.Related issues
Screenshots