Add supported versions to nats tests #16317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
review
refactoring
:Testing
Team:Services
jsoriano
force-pushed
the
nats-docker-tests
branch
from
b0d4fdd
to
ba3daf3
Compare
jsoriano
force-pushed
the
nats-docker-tests
branch
from
ba3daf3
to
d9dc3fa
Compare
mdelapenya
reviewed
Feb 13, 2020
mdelapenya
reviewed
Feb 13, 2020
mdelapenya
reviewed
Feb 13, 2020
mdelapenya
approved these changes
Feb 13, 2020
ChrsMark
approved these changes
Feb 14, 2020
jsoriano
added
needs_backport
jsoriano
removed
the
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Feb 18, 2020
Add a common entry point to nats docker images so we can use the same docker compose and Dockerfile. Add supported-versions.yml for nats service. Add support for 2.1.4. (cherry picked from commit 46cf3dd)
jsoriano
added a commit
that referenced
this pull request
Feb 18, 2020
kvch
pushed a commit
to kvch/beats
that referenced
this pull request
Feb 20, 2020
Add a common entry point to nats docker images so we can use the same docker compose and Dockerfile. Add supported-versions.yml for nats service. Add support for 2.1.4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
supported-versions.ymlfor nats service.Why is it important?
NATS_VERSIONcan be used now to configure different versions without depending on the name of the service.