[Filebeat] Improve ECS field mappings in aws module #16307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leehinman
added
enhancement
Filebeat
|
Pinging @elastic/siem (Team:SIEM) |
- elb fileset + cloud.provider + event.category + event.kind + event.outcome + http.response.status_code, convert to long + http.request.method, lowercase + tracing.trace.id - s3access fileset + client.address + client.ip + geo + client.user.id + cloud.provider + event.action + event.code + event.duration + event.id + event.kind + event.outcome + http.request.referrer + http.response.status_code + related.user + user_agent - vpcflow fileset + cloud.provider + cloud.account.id + cloud.instance.id + event.kind Closes elastic#16154
leehinman
force-pushed
the
16154_aws_ecs_1.4
branch
from
468fa77
to
0539c3e
Compare
andrewkroh
reviewed
Feb 13, 2020
| value: network | ||
|
|
||
| - convert: | ||
| field: http.response.status_code |
There was a problem hiding this comment.
This can be accomplished in the grok statement by adding :long like we have in %{NUMBER:http.request.body.bytes:long}.
There was a problem hiding this comment.
In general using the grok should also be safer, because if this fails with ignore_failure the data won't be indexed because of a mapping exception (assuming the field is mapped as a long).
It probably would never fail to convert here since the grok has it as a NUMBER, but it's something to keep in mind for other cases.
| value: success | ||
|
|
||
| - set: | ||
| if: 'ctx?.http?.response?.status_code != null && ctx.http.response.status_code > 399' |
There was a problem hiding this comment.
Just a suggestion.
Suggested change
| if: 'ctx?.http?.response?.status_code != null && ctx.http.response.status_code > 399' | |
| if: 'ctx?.http?.response?.status_code != null && ctx.http.response.status_code >= 400' |
|
|
||
| - set: | ||
| if: "ctx?.aws?.s3access?.remote_ip != null" | ||
| field: client.ip |
- improve grok pattern to make status code a long - make status code check more readable - add remote_ip to related.ip
andrewkroh
approved these changes
Feb 20, 2020
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Feb 21, 2020
* Improve ECS field mappings in aws module - elb fileset + cloud.provider + event.category + event.kind + event.outcome + http.response.status_code, convert to long + http.request.method, lowercase + tracing.trace.id - s3access fileset + client.address + client.ip + geo + client.user.id + cloud.provider + event.action + event.code + event.duration + event.id + event.kind + event.outcome + http.request.referrer + http.response.status_code + related.ip + related.user + user_agent - vpcflow fileset + cloud.provider + cloud.account.id + cloud.instance.id + event.kind Closes elastic#16154 (cherry picked from commit 913f7ee)
5 tasks
leehinman
added
v7.7.0
and removed
needs_backport
leehinman
added a commit
that referenced
this pull request
Feb 21, 2020
* Improve ECS field mappings in aws module - elb fileset + cloud.provider + event.category + event.kind + event.outcome + http.response.status_code, convert to long + http.request.method, lowercase + tracing.trace.id - s3access fileset + client.address + client.ip + geo + client.user.id + cloud.provider + event.action + event.code + event.duration + event.id + event.kind + event.outcome + http.request.referrer + http.response.status_code + related.ip + related.user + user_agent - vpcflow fileset + cloud.provider + cloud.account.id + cloud.instance.id + event.kind Closes #16154 (cherry picked from commit 913f7ee)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elb fileset
s3access fileset
vpcflow fileset
Closes #16154
What does this PR do?
Why is it important?
Checklist
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs