Add database_account azure metricset #16234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narph
added
[zube]: In Progress
Metricbeat
exekias
reviewed
Feb 25, 2020
| "databasename" : "testdb" | ||
| }, | ||
| "database_account" : { | ||
| "timegrain" : "PT5M", |
There was a problem hiding this comment.
is this field mapped by fields.yml?, we may need to add an entry
There was a problem hiding this comment.
perhaps we should move it to azure.timegrain? as it's common to all metricsets
There was a problem hiding this comment.
indeed, I have moved timegrain inside the azure object as this is a common property for all metricsets
exekias
reviewed
Feb 25, 2020
| default: true | ||
| input: | ||
| module: azure | ||
| metricset: monitor |
exekias
reviewed
Feb 25, 2020
| }, | ||
| "database_account" : { | ||
| "timegrain" : "PT5M", | ||
| "provisionedthroughput" : { |
There was a problem hiding this comment.
Are we grouping metrics with the same dimensions & resource in a single document? That would save some space and make queries faster
There was a problem hiding this comment.
yes, all metrics with the same timegrain, dimension and resource are grouped in the same event
exekias
approved these changes
Feb 26, 2020
narph
added a commit
to narph/beats
that referenced
this pull request
Feb 27, 2020
* add metricset * work on database_Account * fix * work on tests * mage fmt update * work on manifest * update json * move timegrain * uppercase (cherry picked from commit 6816bb1)
narph
added
test-plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve #15758
Lightweight metricset based on
monitorConfig:
extra config options as in the other metricsets:
The metrics in https://docs.microsoft.com/en-us/azure/azure-monitor/platform/metrics-supported#microsoftdocumentdbdatabaseaccounts should be retrieved.
The
DatabaseNamedimension is applied for the metrics which support it.cc: @sorantis