Change lookup_field to service.address. #15883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etting application_id
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
@exekias we found this regression during rebase. seems like the field was renamed as part of ecs standardization. |
|
Thank you for contributing! Could you please update ok to test |
exekias
added
bug
containers
|
Updated CHANGELOG.next.asciidoc. Thanks |
exekias
pushed a commit
to exekias/beats
that referenced
this pull request
Jan 29, 2020
* Change lookup_field to service.address. Using metricset.host is not setting application_id (cherry picked from commit f179f39)
exekias
pushed a commit
that referenced
this pull request
Feb 5, 2020
* Change lookup_field to service.address. Using metricset.host is not setting application_id (cherry picked from commit f179f39) Co-authored-by: premendrasingh <premendrasingh@hotmail.com> Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: metricset.host needs to be changed to service.address so that metrics are enriched as expected.
This PR changes metricset.host to service.address Without this change the enrichment of metrics fails.