Cherry-pick #15597 to 7.6: Backport Packetbeat TLS: Replace array fields with keyword #15601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of `type: array` in some fields (which was inconsistent) causes those fields to be excluded from the template. This prevents pointing aliases to those fields, which we need in 7.6+. Setting those fields to `keyword` explicitly so that they are included in the template. Fixes elastic#15588
adriansr
commented
Jan 15, 2020
Comment on lines
-624
to
-631
| - name: tls.server_certificate_chain | ||
| type: alias | ||
| path: tls.detailed.server_certificate_chain | ||
|
|
||
| - name: tls.client_certificate_chain | ||
| type: alias | ||
| path: tls.detailed.client_certificate_chain | ||
|
|
There was a problem hiding this comment.
These aliases need to be removed because it's not possible to point an alias to an object.
andrewkroh
approved these changes
Jan 15, 2020
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Jan 16, 2020
Use of `type: array` in some fields (which was inconsistent) causes those fields to be excluded from the template. This prevents pointing aliases to those fields, which we need in 7.6+. Setting those fields to `keyword` explicitly so that they are included in the template. Fixes elastic#15588 (cherry picked from commit 04a9058)
adriansr
added a commit
that referenced
this pull request
Jan 17, 2020
Use of `type: array` in some fields (which was inconsistent) causes those fields to be excluded from the template. This prevents pointing aliases to those fields, which we need in 7.6+. Setting those fields to `keyword` explicitly so that they are included in the template. Fixes #15588 (cherry picked from commit 04a9058)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of
type: arrayin some fields (which was inconsistent) causesthose fields to be excluded from the template. This prevents pointing
aliases to those fields, which we need in 7.6+.
Setting those fields to
keywordexplicitly so that they are includedin the template.
Fixes #15588