-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove -i from go build #14556
remove -i from go build #14556
Conversation
Jenkins, test this. |
I don't know why @elastic/observability have we had problems with broken unit tests in metricbeat recently? |
It's the first time I see this one, let me dig into it. I also see some Auditbeat tests failing. Note: I think |
I think this failure is related to file permissions, it would seem like @graphaelli could you please fix the double running issue to see if that's what's going on? |
looks like everything is passing now |
-i was introduced to speed up build speed, see #4758 but as @graphaelli mentioned, not needed anymore. |
failure is unrelated, since Gil is out today i'll do the honours |
As reported in elastic/apm-server#2885 by @BlackYoup,
go build -i
doesn't seem to make much sense as we use it since go 1.10+. This change is needed to avoid reverting elastic/apm-server#2906 at the next beats update.