Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove -i from go build #14556

Merged
merged 5 commits into from
Nov 20, 2019
Merged

remove -i from go build #14556

merged 5 commits into from
Nov 20, 2019

Conversation

graphaelli
Copy link
Member

@graphaelli graphaelli commented Nov 15, 2019

As reported in elastic/apm-server#2885 by @BlackYoup, go build -i doesn't seem to make much sense as we use it since go 1.10+. This change is needed to avoid reverting elastic/apm-server#2906 at the next beats update.

@graphaelli graphaelli requested a review from urso November 15, 2019 19:34
@urso
Copy link

urso commented Nov 18, 2019

Jenkins, test this.

@urso urso self-assigned this Nov 18, 2019
@urso
Copy link

urso commented Nov 19, 2019

I don't know why go build -i is used. But I noticed that metricbeat (and others) unit tests are failing. Trying to restart tests didn't resolve it. Can you rebase on top of master, in case it's a problem with metricbeat itself?

@elastic/observability have we had problems with broken unit tests in metricbeat recently?

@exekias
Copy link
Contributor

exekias commented Nov 19, 2019

It's the first time I see this one, let me dig into it. I also see some Auditbeat tests failing.

Note: I think @elastic/observability is probably too wide, you can use @elastic/integrations better

@exekias
Copy link
Contributor

exekias commented Nov 19, 2019

I think this failure is related to file permissions, it would seem like BEAT_STRICT_PERMS=false is not being passed. On the other side, some more recent PRs are passing these tests (ie #14602).

@graphaelli could you please fix the double running issue to see if that's what's going on?

@graphaelli
Copy link
Member Author

looks like everything is passing now

@ruflin
Copy link
Collaborator

ruflin commented Nov 20, 2019

-i was introduced to speed up build speed, see #4758 but as @graphaelli mentioned, not needed anymore.

@jalvz
Copy link
Contributor

jalvz commented Nov 20, 2019

failure is unrelated, since Gil is out today i'll do the honours

@jalvz jalvz merged commit 360bd93 into elastic:master Nov 20, 2019
@graphaelli graphaelli deleted the no-i-in-go-buld branch November 21, 2019 03:02
graphaelli added a commit to graphaelli/beats that referenced this pull request Jan 10, 2020
graphaelli added a commit that referenced this pull request Jan 13, 2020
@andresrc andresrc added the Team:Integrations Label for the Integrations team label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants