Cherry-pick #14359 to 7.5: [Filebeat] Race condition fix in S3 input plugin #14402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added missing critical section to prevent race condition during high load * Updated CHANGELOG.next.asciidoc * Fix deadlock issue (cherry picked from commit 5fb4e5f)
ChrsMark
approved these changes
Nov 7, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…stic#14402) * Added missing critical section to prevent race condition during high load * Updated CHANGELOG.next.asciidoc * Fix deadlock issue (cherry picked from commit 8531cfb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #14359 to 7.5 branch. Original message:
During high load, Filebeat may crash due to the error channel
c.errChaving been closed before the last event has been acknowledged. This is caused by a missing critical section indone()which can result inc.refsno longer counting as expected.