Update azure error messages when no resources are found #14327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narph
added
Team:Integrations
exekias
reviewed
Oct 30, 2019
| @@ -81,7 +81,7 @@ func (client *Client) InitResources(fn mapMetric, report mb.ReporterV2) error { | |||
| // users could add or remove resources while metricbeat is running so we could encounter the situation where resources are unavailable, we log and create an event if this is the case (see above) | |||
| // but we return an error when absolutely no resources are found | |||
There was a problem hiding this comment.
this comments needs to be updated I guess?
exekias
reviewed
Oct 30, 2019
| @@ -81,7 +81,7 @@ func (client *Client) InitResources(fn mapMetric, report mb.ReporterV2) error { | |||
| // users could add or remove resources while metricbeat is running so we could encounter the situation where resources are unavailable, we log and create an event if this is the case (see above) | |||
| // but we return an error when absolutely no resources are found | |||
| if len(metrics) == 0 { | |||
| return errors.New("no resources were found based on all the configurations options entered") | |||
| client.Log.Error("no resources were found based on all the configurations options entered") | |||
There was a problem hiding this comment.
I wonder if this should be a debug message?
There was a problem hiding this comment.
I have no preference here, since this is not necessary an exception it could be a debug message instead
exekias
added
needs_backport
exekias
approved these changes
Oct 30, 2019
kaiyan-sheng
approved these changes
Oct 30, 2019
narph
added a commit
to narph/beats
that referenced
this pull request
Oct 30, 2019
* Limit error messages to log only * Changelog update * Update comments (cherry picked from commit 36da195)
narph
removed
the
needs_backport
jorgemarey
pushed a commit
to jorgemarey/beats
that referenced
this pull request
Jun 8, 2020
* Limit error messages to log only * Changelog update * Update comments
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
… resources are found (elastic#14339) * Update azure error messages when no resources are found (elastic#14327) * Limit error messages to log only * Changelog update * Update comments (cherry picked from commit d5467aa) * Rezolve conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #14317