-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix date parsing in MySQL error fileset #14130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MySQL error logs can contain timestamps with or without timezones, add date parsers for both cases. Also remove some spurious spaces from parsed messages.
7b38787
to
79e9b6f
Compare
jsoriano
commented
Oct 18, 2019
vagrant@precise32:~$ less /var/log/mysql/ | ||
error.log mysql-slow.log | ||
vagrant@precise32:~$ less /var/log/mysql/error.log | ||
vagrant@precise32:~$ cat /var/log/mysql/error.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess these lines were here by mistake.
exekias
approved these changes
Oct 18, 2019
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Oct 18, 2019
MySQL error logs can contain timestamps with or without timezones, add date parsers for both cases. Also remove some spurious spaces from parsed messages, and add previously unsupported date patterns. Consider lines without timestamp as part of the previous message. If not, lines without timestamp will appear disordered respect to lines with timestamps in Kibana. And joined lines are always related, at least in the tests cases we have. (cherry picked from commit cf5595a)
jsoriano
added a commit
that referenced
this pull request
Oct 27, 2019
MySQL error logs can contain timestamps with or without timezones, add date parsers for both cases. Also remove some spurious spaces from parsed messages, and add previously unsupported date patterns. Consider lines without timestamp as part of the previous message. If not, lines without timestamp will appear disordered respect to lines with timestamps in Kibana. And joined lines are always related, at least in the tests cases we have. (cherry picked from commit cf5595a)
jorgemarey
pushed a commit
to jorgemarey/beats
that referenced
this pull request
Jun 8, 2020
MySQL error logs can contain timestamps with or without timezones, add date parsers for both cases. Also remove some spurious spaces from parsed messages, and add previously unsupported date patterns. Consider lines without timestamp as part of the previous message. If not, lines without timestamp will appear disordered respect to lines with timestamps in Kibana. And joined lines are always related, at least in the tests cases we have.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
MySQL error logs can contain timestamps with or without timezones, add date parsers for both cases. Also remove some spurious spaces from parsed messages, and add previously unsupported date patterns. Consider lines without timestamp as part of the previous message. If not, lines without timestamp will appear disordered respect to lines with timestamps in Kibana. And joined lines are always related, at least in the tests cases we have. (cherry picked from commit dd49581)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL error logs can contain timestamps with or without timezones, add
date parsers for both cases. Also remove some spurious spaces from
parsed messages, and add previously unsupported date patterns.
Consider lines without timestamp as part of the previous message, if
not, lines without timestamp will appear disordered respect to lines with
timestamps in Kibana. And joined lines are always related, at least in
the cases we have.
Fixes #14076