Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix azure fields names #14098

Merged
merged 9 commits into from
Oct 18, 2019
Merged

Fix azure fields names #14098

merged 9 commits into from
Oct 18, 2019

Conversation

narph
Copy link
Contributor

@narph narph commented Oct 16, 2019

Replaced type with provider and resource_group with group in the azure resource object.

@narph narph requested a review from a team as a code owner October 16, 2019 19:05
@narph narph self-assigned this Oct 16, 2019
@narph narph added Team:Integrations Label for the Integrations team Filebeat Filebeat labels Oct 16, 2019
@narph narph requested a review from exekias October 16, 2019 19:10
@narph
Copy link
Contributor Author

narph commented Oct 16, 2019

jenkins test this

1 similar comment
@narph
Copy link
Contributor Author

narph commented Oct 17, 2019

jenkins test this

@exekias exekias added needs_backport PR is waiting to be backported to other branches. v7.5.0 labels Oct 17, 2019
type: keyword
description: >
Initiated by user
- name: http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something looks wrong here, is this the expected field name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@exekias , yes:
azure.activitylogs.identity.claims.name
azure.activitylogs.identity.claims.http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name
azure.activitylogs.identity.claims.http://schemas.xmlsoap.org/ws/2005/05/identity/claims/givenname
azure.activitylogs.identity.claims.http://schemas.xmlsoap.org/ws/2005/05/identity/claims/surname

are used as filters for the dashboards.

An example of the filebeat index (when the activity has been initiated by an user):

....
 "claims" : {
                  "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/nameidentifier" : "...",
                  "aio" : "...",
                  "iss" : "...",
                  "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/upn" : ...",
                  "puid" : "...",
                  "wids" : "...",
                  "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/givenname" : "...",
                  "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/surname" : "...",
                  "exp" : "1571242827",
                  "ipaddr" : "...",
                  "iat" : "...",
                  "ver" : "1.0",
                  "groups" : "...",
                  "http://schemas.microsoft.com/claims/authnmethodsreferences" : "pwd",
                  "uti" : "...",
                  "aud" : "https://management.core.windows.net/",
                  "http://schemas.microsoft.com/claims/authnclassreference" : "1",
                  "nbf" : "...",
                  "appidacr" : "2",
                  "http://schemas.microsoft.com/identity/claims/tenantid" : "...",
                  "appid" : "...",
                  "name" : "...",
                  "http://schemas.microsoft.com/identity/claims/objectidentifier" : "...",
                  "http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name" : "...",
                  "http://schemas.microsoft.com/identity/claims/scope" : "user_impersonation"
                }
....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh understood, thanks. What about the rest of claims in that example? I see aio, iss and many more. Should we map those?

@narph narph requested a review from exekias October 17, 2019 13:03
@narph narph merged commit 6f9dcd9 into elastic:master Oct 18, 2019
@narph narph deleted the fix-filebeat-azure-fields branch October 18, 2019 13:56
narph added a commit to narph/beats that referenced this pull request Oct 18, 2019
* Fix azure fields names

* Add changelog entry

* Add claims fields

* Add "claims.name" field (dashboards)

* Create claims_initiated_by object

* REmove dummy pipeline file

* Fix condition on category and initiated_by fields

(cherry picked from commit 6f9dcd9)
narph added a commit that referenced this pull request Oct 18, 2019
* Fix azure fields names (#14098)

* Fix azure fields names

* Add changelog entry

* Add claims fields

* Add "claims.name" field (dashboards)

* Create claims_initiated_by object

* REmove dummy pipeline file

* Fix condition on category and initiated_by fields

(cherry picked from commit 6f9dcd9)

* Changelog cleanup
@narph narph removed the needs_backport PR is waiting to be backported to other branches. label Jan 15, 2020
jorgemarey pushed a commit to jorgemarey/beats that referenced this pull request Jun 8, 2020
* Fix azure fields names

* Add changelog entry

* Add claims fields

* Add "claims.name" field (dashboards)

* Create claims_initiated_by object

* REmove dummy pipeline file

* Fix condition on category and initiated_by fields
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
* Fix azure fields names (elastic#14098)

* Fix azure fields names

* Add changelog entry

* Add claims fields

* Add "claims.name" field (dashboards)

* Create claims_initiated_by object

* REmove dummy pipeline file

* Fix condition on category and initiated_by fields

(cherry picked from commit 87deb79)

* Changelog cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Filebeat Filebeat Team:Integrations Label for the Integrations team v7.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants