Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure Dashboard #14000

Merged
merged 9 commits into from
Oct 11, 2019
Merged

Add Azure Dashboard #14000

merged 9 commits into from
Oct 11, 2019

Conversation

sorantis
Copy link
Contributor

@sorantis sorantis commented Oct 10, 2019

These dashboards visualize metrics for Azure virtual machines, vm guest metrics, virtual machine scale sets.

metricbeat-azure-vm-overview

metricbeat-azure-vm-guestmetrics-overview

metricbeat-azure-vmss-overview

@sorantis sorantis requested a review from a team as a code owner October 10, 2019 12:23
@sorantis sorantis added Team:Integrations Label for the Integrations team enhancement Metricbeat Metricbeat and removed Team:Integrations Label for the Integrations team labels Oct 10, 2019
@narph narph self-requested a review October 10, 2019 15:20
@narph
Copy link
Contributor

narph commented Oct 10, 2019

Tested it out, LGTM

@kaiyan-sheng
Copy link
Contributor

LGTM, just curious why in these dashboards, the Filters section is different?

@sorantis
Copy link
Contributor Author

LGTM, just curious why in these dashboards, the Filters section is different?

Mainly because the dashboards show different entities: VMSS consist of VMs, so in addition to Region and Resource Group the user might want to drill down to a particular VM in a VMSS and check metrics for it. For Guest metrics the use case is the same - show ASP.NET, SQL Server metrics for a particular VM instead of an aggregate.

@kaiyan-sheng
Copy link
Contributor

LGTM, just curious why in these dashboards, the Filters section is different?

Mainly because the dashboards show different entities: VMSS consist of VMs, so in addition to Region and Resource Group the user might want to drill down to a particular VM in a VMSS and check metrics for it. For Guest metrics the use case is the same - show ASP.NET, SQL Server metrics for a particular VM instead of an aggregate.

Thanks for the explanation. For Compute VM Overview, will it be helpful to add VM name as a filter for user to drill down as well?

CI is not happy with the json file:

2019-10-10T15:18:17.852Z	ERROR	instance/beat.go:886	Exiting: Failed to import dashboard: Failed to load directory /go/src/github.com/elastic/beats/x-pack/metricbeat/build/system-tests/run/test_xpack_base.Test.test_dashboards/kibana/7/dashboard:
  error loading /go/src/github.com/elastic/beats/x-pack/metricbeat/build/system-tests/run/test_xpack_base.Test.test_dashboards/kibana/7/dashboard/Metricbeat-azure-vm-guestmetrics-overview.json: returned 400 to import file: <nil>. Response: {"statusCode":400,"error":"Bad Request","message":"Document \"64930c20-eaa6-11e9-90ec-112a988266d5\" has property \"visualization\" which belongs to a more recent version of Kibana (7.3.1)."}
  error loading /go/src/github.com/elastic/beats/x-pack/metricbeat/build/system-tests/run/test_xpack_base.Test.test_dashboards/kibana/7/dashboard/Metricbeat-azure-vm-overview.json: returned 400 to import file: <nil>. Response: {"statusCode":400,"error":"Bad Request","message":"Document \"5031b220-eb61-11e9-90ec-112a988266d5\" has property \"visualization\" which belongs to a more recent version of Kibana (7.3.1)."}
  error loading /go/src/github.com/elastic/beats/x-pack/metricbeat/build/system-tests/run/test_xpack_base.Test.test_dashboards/kibana/7/dashboard/Metricbeat-azure-vmss-overview.json: returned 400 to import file: <nil>. Response: {"statusCode":400,"error":"Bad Request","message":"Document \"686bc990-ea92-11e9-90ec-112a988266d5\" has property \"visualization\" which belongs to a more recent version of Kibana (7.3.1)."}
Exiting: Failed to import dashboard: Failed to load directory /go/src/github.com/elastic/beats/x-pack/metricbeat/build/system-tests/run/test_xpack_base.Test.test_dashboards/kibana/7/dashboard:
  error loading /go/src/github.com/elastic/beats/x-pack/metricbeat/build/system-tests/run/test_xpack_base.Test.test_dashboards/kibana/7/dashboard/Metricbeat-azure-vm-guestmetrics-overview.json: returned 400 to import file: <nil>. Response: {"statusCode":400,"error":"Bad Request","message":"Document \"64930c20-eaa6-11e9-90ec-112a988266d5\" has property \"visualization\" which belongs to a more recent version of Kibana (7.3.1)."}
  error loading /go/src/github.com/elastic/beats/x-pack/metricbeat/build/system-tests/run/test_xpack_base.Test.test_dashboards/kibana/7/dashboard/Metricbeat-azure-vm-overview.json: returned 400 to import file: <nil>. Response: {"statusCode":400,"error":"Bad Request","message":"Document \"5031b220-eb61-11e9-90ec-112a988266d5\" has property \"visualization\" which belongs to a more recent version of Kibana (7.3.1)."}
  error loading /go/src/github.com/elastic/beats/x-pack/metricbeat/build/system-tests/run/test_xpack_base.Test.test_dashboards/kibana/7/dashboard/Metricbeat-azure-vmss-overview.json: returned 400 to import file: <nil>. Response: {"statusCode":400,"error":"Bad Request","message":"Document \"686bc990-ea92-11e9-90ec-112a988266d5\" has property \"visualization\" which belongs to a more recent version of Kibana (7.3.1)."}```

@sorantis
Copy link
Contributor Author

For Compute VM Overview, will it be helpful to add VM name as a filter for user to drill down as well?

Added a vm filter.

Regarding the CI error, not sure how to approach solving it. I'm using metricbeat and stack v7.4.0 for exporting dashboards. Is there some incompatibility on the version level?

@sorantis
Copy link
Contributor Author

jenkins test this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Metricbeat Metricbeat Team:Integrations Label for the Integrations team v7.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants