Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the azure module fields #13988

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Update the azure module fields #13988

merged 2 commits into from
Oct 10, 2019
+59 −311

Conversation

narph
Copy link
Contributor

@narph narph commented Oct 9, 2019 •
edited
Loading

resource, namespace, dimensions and subscription id fields were still defined at metricset level although they have been moved to the module level.
Fields have been updated and regenerated.

@narph narph requested a review from a team as a code owner October 9, 2019 16:44
@narph narph self-assigned this Oct 9, 2019
@narph narph added Team:Integrations Label for the Integrations team Metricbeat Metricbeat labels Oct 9, 2019
@narph narph requested a review from jsoriano October 9, 2019 16:45
kaiyan-sheng
kaiyan-sheng reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, are there any .json files need to regenerated after the field name changes?

@narph
Copy link
Contributor Author

narph commented Oct 9, 2019

@kaiyan-sheng, the data.json files examples were updated before this fix. Not sure there is a generator for those.

@kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng, the data.json files examples were updated before this fix. Not sure there is a generator for those.

Interesting, I thought when fields in data.json doesn't match fields.yml, some ci check will fail.

@narph narph merged commit 7468ba9 into elastic:master Oct 10, 2019
@narph narph deleted the fix-metric-template branch October 10, 2019 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng

@jsoriano jsoriano

Assignees

@narph narph

Labels
Metricbeat Metricbeat Team:Integrations Label for the Integrations team v7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@narph @kaiyan-sheng @andresrc