Add job label by default when using Prometheus collector
#13878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
ChrsMark
added
Team:Integrations
zube
bot
added
[zube]: Inbox
and removed
[zube]: (7.5) Planned for release
[zube]: In Review
test-plan
exekias
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
joblabel by default when using prometheus collector. So when using raw Prometheus collector it will always beprometheus.When using lightweight modules it is the name of the lightweight module ie
cockroachdbCloses #12739
Testing:
metrics_path: /metricsin the configuration and collect metrics from anode-exporterdirectly.metrics_path: '/federate'and collect metrics from Prometheus server.In both cases label
jobshould be present.https://www.elastic.co/guide/en/beats/metricbeat/master/metricbeat-metricset-prometheus-collector.html
Extra: Try the same with
cockroachdblightweight module. Unitest's testdata cover this case too.