[Filebeat] Fix bugs in Netflow input #13821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an error the expiration loop was expiring the sessions twice in each iteration. This caused all the sessions to be expired wether active or not, every time that the expiration interval elapsed.
The NetFlow input was mistakenly comparing sequence numbers (v9 and IPFIX) from the same source but different Observation Domain (aka Source ID). This caused the session to be reset when packets from different source IDs where interweaved. This refactors the source ID out of session and into the session key, so that now a different source ID from the same source creates a new session.
|
Pinging @elastic/siem |
houndci-bot
reviewed
Sep 27, 2019
adriansr
added
the
needs_backport
andrewkroh
approved these changes
Sep 27, 2019
There was a problem hiding this comment.
Lots of good fixes here. This should also close #13699 IIUC.
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Sep 30, 2019
This commit fixes a couple bugs in the Netflow input causing flow loss in Netflow V9 and IPFIX: Due to an error the expiration loop was expiring the sessions twice in each iteration. This caused all the sessions to be expired wether active or not, every time that the expiration interval elapsed. The NetFlow input was mistakenly comparing sequence numbers (v9 and IPFIX) from the same source but different Observation Domain (aka Source ID). This caused the session to be reset when packets from different source IDs where interweaved. This refactors the source ID out of session and into the session key, so that now a different source ID from the same source creates a new session. (cherry picked from commit 62d0e87)
adriansr
added
v7.4.0
and removed
needs_backport
adriansr
added a commit
that referenced
this pull request
Sep 30, 2019
This commit fixes a couple bugs in the Netflow input causing flow loss in Netflow V9 and IPFIX: Due to an error the expiration loop was expiring the sessions twice in each iteration. This caused all the sessions to be expired wether active or not, every time that the expiration interval elapsed. The NetFlow input was mistakenly comparing sequence numbers (v9 and IPFIX) from the same source but different Observation Domain (aka Source ID). This caused the session to be reset when packets from different source IDs where interweaved. This refactors the source ID out of session and into the session key, so that now a different source ID from the same source creates a new session. (cherry picked from commit 62d0e87)
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Oct 14, 2019
This commit fixes a couple bugs in the Netflow input causing flow loss in Netflow V9 and IPFIX: Due to an error the expiration loop was expiring the sessions twice in each iteration. This caused all the sessions to be expired wether active or not, every time that the expiration interval elapsed. The NetFlow input was mistakenly comparing sequence numbers (v9 and IPFIX) from the same source but different Observation Domain (aka Source ID). This caused the session to be reset when packets from different source IDs where interweaved. This refactors the source ID out of session and into the session key, so that now a different source ID from the same source creates a new session. (cherry picked from commit 62d0e87)
adriansr
added a commit
that referenced
this pull request
Oct 14, 2019
This commit fixes a couple bugs in the Netflow input causing flow loss in Netflow V9 and IPFIX: Due to an error the expiration loop was expiring the sessions twice in each iteration. This caused all the sessions to be expired wether active or not, every time that the expiration interval elapsed. The NetFlow input was mistakenly comparing sequence numbers (v9 and IPFIX) from the same source but different Observation Domain (aka Source ID). This caused the session to be reset when packets from different source IDs where interweaved. This refactors the source ID out of session and into the session key, so that now a different source ID from the same source creates a new session. (cherry picked from commit 62d0e87)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
elastic#13846) This commit fixes a couple bugs in the Netflow input causing flow loss in Netflow V9 and IPFIX: Due to an error the expiration loop was expiring the sessions twice in each iteration. This caused all the sessions to be expired wether active or not, every time that the expiration interval elapsed. The NetFlow input was mistakenly comparing sequence numbers (v9 and IPFIX) from the same source but different Observation Domain (aka Source ID). This caused the session to be reset when packets from different source IDs where interweaved. This refactors the source ID out of session and into the session key, so that now a different source ID from the same source creates a new session. (cherry picked from commit 2da3e27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple bugs in the Netflow input causing flow loss in Netflow V9 and IPFIX:
It's easier to review by looking at the individual commits.
Closes #13699