-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] Ignore prometheus untyped metrics with NaN/Inf #13790
Conversation
metricbeat/module/prometheus/collector/_meta/testdata/etcd-3.3.10-partial.plain-expected.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but changes in the helper would need an additional changelog entry, and some tests.
The fix in the collector metricset should be backported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Merging this PR. I think CI failure is not related. |
…ped metrics with NaN/Inf (elastic#13801) * [Metricbeat] Ignore prometheus untyped metrics with NaN/Inf (elastic#13790) (cherry picked from commit 38f3301)
…ped metrics with NaN/Inf (elastic#13800) * [Metricbeat] Ignore prometheus untyped metrics with NaN/Inf (elastic#13790) (cherry picked from commit 38f3301)
If a metric with
untyped
type has NaN as value, metricbeat reports errorunsupported float value: NaN
.This is missed from #12084 and also came up in Discuss Forum tickets.
closes #13750