Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Ignore prometheus untyped metrics with NaN/Inf #13790

Merged
merged 3 commits into from
Sep 25, 2019
Merged

[Metricbeat] Ignore prometheus untyped metrics with NaN/Inf #13790

merged 3 commits into from
Sep 25, 2019
+141 −108

Conversation

kaiyan-sheng
Copy link
Contributor

If a metric with untyped type has NaN as value, metricbeat reports error unsupported float value: NaN.

This is missed from #12084 and also came up in Discuss Forum tickets.

closes #13750

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner September 24, 2019 20:01
@kaiyan-sheng kaiyan-sheng self-assigned this Sep 24, 2019
@kaiyan-sheng kaiyan-sheng mentioned this pull request Sep 24, 2019
Closed
jsoriano
jsoriano reviewed Sep 25, 2019
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but changes in the helper would need an additional changelog entry, and some tests.

The fix in the collector metricset should be backported.

@jsoriano jsoriano added Team:Integrations Label for the Integrations team [zube]: In Review Metricbeat Metricbeat module needs_backport PR is waiting to be backported to other branches. review v7.3.3 v7.4.1 v7.5.0 labels Sep 25, 2019
jsoriano
jsoriano approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaiyan-sheng
Copy link
Contributor Author

Merging this PR. I think CI failure is not related.

@kaiyan-sheng kaiyan-sheng merged commit f59deb0 into elastic:master Sep 25, 2019
@kaiyan-sheng kaiyan-sheng deleted the prometheus_nan branch September 25, 2019 16:57
@kaiyan-sheng kaiyan-sheng mentioned this pull request Sep 25, 2019
Merged
@kaiyan-sheng kaiyan-sheng removed the needs_backport PR is waiting to be backported to other branches. label Sep 25, 2019
@kaiyan-sheng kaiyan-sheng mentioned this pull request Sep 25, 2019
Merged
kaiyan-sheng added a commit that referenced this pull request Sep 25, 2019
@kaiyan-sheng
Cherry-pick #13790 to 7.3: [Metricbeat] Ignore prometheus untyped met…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f292b86 
…rics with NaN/Inf (#13800)

* [Metricbeat] Ignore prometheus untyped metrics with NaN/Inf (#13790)
(cherry picked from commit f59deb0)
kaiyan-sheng added a commit that referenced this pull request Sep 25, 2019
@kaiyan-sheng
Cherry-pick #13790 to 7.4: [Metricbeat] Ignore prometheus untyped met…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9fcd731 
…rics with NaN/Inf (#13801)

* [Metricbeat] Ignore prometheus untyped metrics with NaN/Inf (#13790)
(cherry picked from commit f59deb0)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@kaiyan-sheng
Cherry-pick elastic#13790 to 7.4: [Metricbeat] Ignore prometheus unty…
4acecd0 
…ped metrics with NaN/Inf (elastic#13801)

* [Metricbeat] Ignore prometheus untyped metrics with NaN/Inf (elastic#13790)
(cherry picked from commit 38f3301)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@kaiyan-sheng
Cherry-pick elastic#13790 to 7.3: [Metricbeat] Ignore prometheus unty…
12000e7 
…ped metrics with NaN/Inf (elastic#13800)

* [Metricbeat] Ignore prometheus untyped metrics with NaN/Inf (elastic#13790)
(cherry picked from commit 38f3301)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
Metricbeat Metricbeat module review Team:Integrations Label for the Integrations team v7.3.3 v7.4.0 v7.4.1 v7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prometheus untyped metrics with NaN value generate incorrect events
3 participants
@kaiyan-sheng @jsoriano @andresrc