-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change config example that shows how to turn off process monitoring #1365
Conversation
period: 10 | ||
procs: ["^$"] | ||
stats: | ||
process: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@monicasarbu is this proc
or process
? See https://github.com/elastic/beats/blob/1.1/topbeat/etc/topbeat.yml#L18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dedemorton @monicasarbu This PR is against 1.1. The change from @tsg is against 1.2. So not sure if it is |
@dedemorton Looks ok. But that would mean our config file for 1.1 is wrong: https://github.com/elastic/beats/blob/1.1/topbeat/etc/topbeat.yml#L18 |
@monicasarbu @ruflin I'm not sure how to proceed here. Is the config file wrong? If so, can we fix it, or do I need to document that it's wrong? |
I think the config in 1.1 is wrong and we should fix the config, not the docs, but I would like @monicasarbu to confirm. |
@ruflin yes, that's right. I think I fixed only the tests (to change from proc to process) and I didn't change the actual config in 1.1, but it's fixed in 1.2. |
Cherry-pick proc monitoring example change into 1.1