Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change config example that shows how to turn off process monitoring #1365

Merged
merged 1 commit into from
Apr 11, 2016

Conversation

dedemorton
Copy link
Contributor

Cherry-pick proc monitoring example change into 1.1

period: 10
procs: ["^$"]
stats:
process: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruflin Yes, it's process. I have updated it only in the tests. There was already a fix from the community and merged by @tsg: #1343

@monicasarbu monicasarbu merged commit a27cba9 into elastic:1.1 Apr 11, 2016
@ruflin
Copy link
Member

ruflin commented Apr 12, 2016

@dedemorton @monicasarbu This PR is against 1.1. The change from @tsg is against 1.2. So not sure if it is process in 1.1?

@dedemorton
Copy link
Contributor Author

@ruflin I saw this commit and figured that the change was in for 1.1. Am I mistaken? a14ecfd

@ruflin
Copy link
Member

ruflin commented Apr 12, 2016

@dedemorton Looks ok. But that would mean our config file for 1.1 is wrong: https://github.com/elastic/beats/blob/1.1/topbeat/etc/topbeat.yml#L18

@dedemorton
Copy link
Contributor Author

@monicasarbu @ruflin I'm not sure how to proceed here. Is the config file wrong? If so, can we fix it, or do I need to document that it's wrong?

@ruflin
Copy link
Member

ruflin commented Apr 15, 2016

I think the config in 1.1 is wrong and we should fix the config, not the docs, but I would like @monicasarbu to confirm.

@monicasarbu
Copy link
Contributor

monicasarbu commented Apr 22, 2016

@ruflin yes, that's right. I think I fixed only the tests (to change from proc to process) and I didn't change the actual config in 1.1, but it's fixed in 1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants