[SIEM] [Auditbeat] system/socket: Fix UDP flows #13470
Merged
+428
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a few problems with UDP: - IPv6/UDP unconnected support. - Lost packets in UDP due to using zero-destination address. - Added more tests
|
Pinging @elastic/siem |
adriansr
added
the
needs_backport
Not available in Windows CI workers
5 tasks
andrewkroh
approved these changes
Sep 4, 2019
| @@ -321,7 +321,7 @@ var installKProbes = []helper.ProbeDef{ | |||
| Probe: tracing.Probe{ | |||
| Name: "udp_sendmsg_in", | |||
| Address: "udp_sendmsg", | |||
| Fetchargs: "sock={{.UDP_SENDMSG_SOCK}} size={{.UDP_SENDMSG_LEN}} laddr=+{{.INET_SOCK_LADDR}}({{.UDP_SENDMSG_SOCK}}):u32 lport=+{{.INET_SOCK_LPORT}}({{.UDP_SENDMSG_SOCK}}):u16 raddr=+{{.SOCKADDR_IN_ADDR}}(+0({{.UDP_SENDMSG_MSG}})):u32 rport=+{{.SOCKADDR_IN_PORT}}(+0({{.UDP_SENDMSG_MSG}})):u16", | |||
| Fetchargs: "sock={{.UDP_SENDMSG_SOCK}} size={{.UDP_SENDMSG_LEN}} laddr=+{{.INET_SOCK_LADDR}}({{.UDP_SENDMSG_SOCK}}):u32 lport=+{{.INET_SOCK_LPORT}}({{.UDP_SENDMSG_SOCK}}):u16 raddr=+{{.SOCKADDR_IN_ADDR}}(+0({{.UDP_SENDMSG_MSG}})):u32 rport=+{{.SOCKADDR_IN_PORT}}(+0({{.UDP_SENDMSG_MSG}})):u16 altraddr=+{{.INET_SOCK_RADDR}}({{.UDP_SENDMSG_SOCK}}):u32 altrport=+{{.INET_SOCK_RPORT}}({{.UDP_SENDMSG_SOCK}}):u16", | |||
There was a problem hiding this comment.
In what cases are the alt addrs needed?
There was a problem hiding this comment.
Sometimes, for connected sockets, the alt addresses are zero and the non-alt are populated.
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Sep 5, 2019
This fixes a few problems with UDP: - IPv6/UDP unconnected support. - Lost packets in UDP due to using zero-destination address. - Added more tests (cherry picked from commit f0e2e20)
adriansr
added
v7.4.0
and removed
needs_backport
adriansr
added a commit
that referenced
this pull request
Sep 5, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…tic#13513) This fixes a few problems with UDP: - IPv6/UDP unconnected support. - Lost packets in UDP due to using zero-destination address. - Added more tests (cherry picked from commit 7dd2735)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few problems with UDP:
Added more tests.
Relates #13058