-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[metricbeat] first pass at adding vmstats to system/memory #13322
[metricbeat] first pass at adding vmstats to system/memory #13322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some suggestions on field names, let me know what you think.
This will also need at least a changelog entry.
Alright, pushed a change to to refactor the fields and make them a little more generic. I'm not sure about refactoring the |
0175973
to
8bc7031
Compare
Bah, forgot to add a changelog entry |
See #13175
This PR adds swap data from
/proc/vmstat
under linux to the system/memory metricset.I wasn't sure how we wanted to add linux vmstat data to the memory metricset, so this is the most conservative implementation, which just adds swap data, in line with the original request. The vmstat data as a whole is quite large, so I didn't want to go ahead and just add everything.
We also had to update the
go-sysinfo
repo, hence why this PR is so large.