Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metricbeat] first pass at adding vmstats to system/memory #13322

Merged

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Aug 22, 2019

See #13175

This PR adds swap data from /proc/vmstat under linux to the system/memory metricset.

I wasn't sure how we wanted to add linux vmstat data to the memory metricset, so this is the most conservative implementation, which just adds swap data, in line with the original request. The vmstat data as a whole is quite large, so I didn't want to go ahead and just add everything.

We also had to update the go-sysinfo repo, hence why this PR is so large.

@fearful-symmetry fearful-symmetry added enhancement Team:Integrations Label for the Integrations team labels Aug 22, 2019
@fearful-symmetry fearful-symmetry requested review from a team August 22, 2019 19:20
@fearful-symmetry fearful-symmetry self-assigned this Aug 22, 2019
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some suggestions on field names, let me know what you think.

This will also need at least a changelog entry.

@fearful-symmetry
Copy link
Contributor Author

Alright, pushed a change to to refactor the fields and make them a little more generic. I'm not sure about refactoring the VMStat call, since right now all the modifications we're making to the MapStr structure are happening in one place, and obscuring what we're doing to a different library entirely seems like a recipe for confusion later on.

@fearful-symmetry
Copy link
Contributor Author

Bah, forgot to add a changelog entry

@fearful-symmetry fearful-symmetry merged commit eb5a3d7 into elastic:master Aug 29, 2019
@urso urso added the v7.5.0 label Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants