Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generator tests to OSX travis builds #13210

Merged
merged 3 commits into from
Aug 22, 2019
Merged

Add generator tests to OSX travis builds #13210

merged 3 commits into from
Aug 22, 2019

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Aug 9, 2019

No description provided.

@jsoriano jsoriano added :Testing :Generator Related to code generators for building custom Beats or modules. labels Aug 9, 2019
@jsoriano jsoriano self-assigned this Aug 9, 2019
@jsoriano jsoriano mentioned this pull request Aug 9, 2019
Merged
@jsoriano
Copy link
Member Author

jsoriano commented Aug 9, 2019

jenkins, test this again please

@jsoriano jsoriano added the review label Aug 9, 2019
@jsoriano jsoriano marked this pull request as ready for review August 9, 2019 14:47
@jsoriano
Copy link
Member Author

jsoriano commented Aug 9, 2019

jenkins, test this again please

@jsoriano jsoriano added in progress Pull request is currently in progress. and removed review labels Aug 9, 2019
@jsoriano
Copy link
Member Author

jsoriano commented Aug 9, 2019

Merged with #13193 to test the change there on OSX.

@jsoriano jsoriano added review and removed in progress Pull request is currently in progress. labels Aug 15, 2019
fearful-symmetry
fearful-symmetry approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@fearful-symmetry fearful-symmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, LGTM

@jsoriano jsoriano merged commit 9cfc4e3 into elastic:master Aug 22, 2019
@jsoriano jsoriano deleted the test-generator-osx branch August 22, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fearful-symmetry fearful-symmetry fearful-symmetry approved these changes

Assignees

@jsoriano jsoriano

Labels
:Generator Related to code generators for building custom Beats or modules. review :Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsoriano @fearful-symmetry