Cherry-pick #12816 to 7.2: [Metricbeat] Avoid omitting of errors in Vsphere module and upgrade to use context.Context #13004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if err := mbtest.WriteEventsReporterV2Error(f, t, ""); err != nil { | ||
| if err := mbtest.WriteEventsReporterV2WithContext(f, t, ""); err != nil { |
There was a problem hiding this comment.
WriteEventsReporterV2WithContext seems to be undefined for 7.2, maybe we should keep WriteEventsReporterV2Error here?
There was a problem hiding this comment.
🤦♂️ Yeap, good catch 😬
…o use context.Context (elastic#12816) (cherry picked from commit 8f8d0b3)
sayden
force-pushed
the
backport_12816_7.2
branch
from
d74756a to
de110a0
Compare
kaiyan-sheng
approved these changes
Jul 31, 2019
|
Error seems unrelated, merging |
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…rs in Vsphere module and upgrade to use context.Context (elastic#13004)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #12816 to 7.2 branch. Original message:
Some potential error checks are being omitted in vSphere module. They aren't probably key to fetch metrics but they may be hiding important debug information when things go wrong.
This PR prints in debug level if any of those errors have returned information.
At the same time, the PR is upgraded to use
context.Contextin Fetch method, recently added to Beats and it may be useful as a background context was being used on the Metricsets.