Account for no load average reported by ES on Windows #12866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
bug
module
review
Metricbeat
|
Pinging @elastic/stack-monitoring |
cachedout
approved these changes
Jul 11, 2019
This was referenced Jul 11, 2019
ycombinator
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug reported via https://discuss.elastic.co/t/metricbeat-unable-to-ship-monitoring-information-on-windows-machine/189956.
When the
elasticsearchmodule is enabled and configured withxpack.enabled: true, thenode_statsmetricset tries to parse CPU load average from the ElasticsearchGET _nodes/_local/statsAPI response. If Elasticsearch is running on Windows, no CPU load average is reported by this API. So Metricbeat currently fails with an error like this:This PR makes the parsing of CPU load average optional so we don't see this error when ES doesn't report the CPU load average, e.g. when it's running on Windows.