Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metricbeat]Add kubernetes scheduler dashboard #12749

Merged
merged 14 commits into from
Jul 4, 2019
Merged

[metricbeat]Add kubernetes scheduler dashboard #12749

merged 14 commits into from
Jul 4, 2019

Conversation

odacremolbap
Copy link
Contributor

Add kubernetes scheduler dashboard

@odacremolbap odacremolbap added the containers Related to containers use case label Jul 2, 2019
@odacremolbap odacremolbap requested a review from a team as a code owner July 2, 2019 07:21
@odacremolbap odacremolbap self-assigned this Jul 2, 2019
@odacremolbap odacremolbap added Metricbeat Metricbeat Team:Integrations Label for the Integrations team in progress Pull request is currently in progress. labels Jul 2, 2019
@odacremolbap
Copy link
Contributor Author

image

jsoriano
jsoriano reviewed Jul 2, 2019
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking quite good, I think this dashboard gives a good overview on how a scheduler is behaving.

Could you also add an screenshot for the documentation?

@odacremolbap
Copy link
Contributor Author

odacremolbap commented Jul 2, 2019 •
edited
Loading

@jsoriano this json you are reviewing is not the one I should be pushing.
this is in progress, and I'm testing removing all contents from the dasboard (CI succeed) or adding some very brief and almost random content (CI fails)

still trying to sort out the beat magic commands to get this right

@odacremolbap odacremolbap requested a review from a team as a code owner July 2, 2019 12:48
@odacremolbap odacremolbap requested a review from jsoriano July 3, 2019 08:59
@odacremolbap odacremolbap added review and removed in progress Pull request is currently in progress. labels Jul 3, 2019
exekias
exekias approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is happy

@cachedout cachedout removed the request for review from a team July 3, 2019 13:30
@odacremolbap odacremolbap requested a review from a team as a code owner July 3, 2019 16:15
@odacremolbap
Copy link
Contributor Author

I'm very sorry to request the review again, but I've added:

  • 30s interval to markdown visualization, since it was going blank often
  • CPU + Memory visualization (to make this par with proxy dashboard)
  • Docs primer (will create an issue to improve once controller-manager and proxy are merged)

@odacremolbap odacremolbap requested a review from exekias July 3, 2019 16:19
@odacremolbap
Copy link
Contributor Author

jenkins, test this my dear

@odacremolbap
Copy link
Contributor Author

jenkins, test this

@sayden sayden self-requested a review July 4, 2019 07:55
@sayden
Copy link
Contributor

sayden commented Jul 4, 2019

Tested locally
image

@odacremolbap odacremolbap added the needs_backport PR is waiting to be backported to other branches. label Jul 4, 2019
@odacremolbap odacremolbap merged commit 97b98ed into elastic:master Jul 4, 2019
@odacremolbap odacremolbap mentioned this pull request Jul 4, 2019
Merged
@odacremolbap odacremolbap deleted the task/kubescheduler-dashboard branch July 4, 2019 14:13
odacremolbap pushed a commit that referenced this pull request Jul 4, 2019
[7.3][metricbeat]Add kubernetes scheduler dashboard (#12749)
a80a1a1 
- Add kubernetes scheduler dashboard (#12749)
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Aug 29, 2019
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
[7.3][metricbeat]Add kubernetes scheduler dashboard (elastic#12749)
a67b81c 
- Add kubernetes scheduler dashboard (elastic#12749)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayden sayden sayden approved these changes

@jsoriano jsoriano Awaiting requested review from jsoriano

@exekias exekias Awaiting requested review from exekias

Assignees

@odacremolbap odacremolbap

Labels
containers Related to containers use case Metricbeat Metricbeat review Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@odacremolbap @sayden @jsoriano @exekias