-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add google-pubsub input type to Filebeat #12746
Merged
andrewkroh
merged 4 commits into
elastic:master
from
andrewkroh:feature/fb/pubsub-input-type
Jul 2, 2019
Merged
Add google-pubsub input type to Filebeat #12746
andrewkroh
merged 4 commits into
elastic:master
from
andrewkroh:feature/fb/pubsub-input-type
Jul 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds v0.40.0 of the cloud.google.com/go/pubsub SDK along with its dependencies.
houndci-bot
reviewed
Jul 2, 2019
houndci-bot
reviewed
Jul 2, 2019
b9cea98
to
fa1471b
Compare
Add new input type for consuming messages from Google Cloud Pub/Sub topic subscriptions.
fa1471b
to
cadf25e
Compare
Pinging @elastic/secops |
I think a botched govendor run might have caused this.
adriansr
approved these changes
Jul 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jenkins, test this |
1 similar comment
jenkins, test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new input type for consuming messages from Google Cloud Pub/Sub topic
subscriptions.
This input can, for example, be used to receive Stackdriver logs that have been exported to a Google Cloud Pub/Sub topic.
Example configuration:
Most of the code is for the GCP SDK and its deps. So I recommend reviewing cadf25e, the Filebeat input code.