Fix race condition on error returned after context cancellation #12743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After elastic#11981 docker client watching event uses the context provided by the metricset wrapper. This produces a race condition on error reporting: the errors channel will receive a context cancelled error when the context is done, so both paths can be chosen by the select. If the errors one is chosen, an error will be reported and a reconnect will be attempted, that will fail. Alternativelly we could have created another context and cancel it after the reporter is done, in a similar fashion to what was done before elastic#11981, but then we would be breaking the chain of derived contexts.
jsoriano
added
module
review
Metricbeat
exekias
approved these changes
Jul 4, 2019
Ok, I will backport this |
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jul 10, 2019
…tic#12743) After elastic#11981 docker client watching event uses the context provided by the metricset wrapper. This produces a race condition on error reporting: the errors channel will receive a context cancelled error when the context is done, so both paths can be chosen by the select. If the errors one is chosen, an error will be reported and a reconnect will be attempted, that will fail. Alternativelly we could have created another context and cancel it after the reporter is done, in a similar fashion to what was done before elastic#11981, but then we would be breaking the chain of derived contexts. (cherry picked from commit d36878a)
jsoriano
added a commit
that referenced
this pull request
Jul 11, 2019
…) (#12849) After #11981 docker client watching event uses the context provided by the metricset wrapper. This produces a race condition on error reporting: the errors channel will receive a context cancelled error when the context is done, so both paths can be chosen by the select. If the errors one is chosen, an error will be reported and a reconnect will be attempted, that will fail. Alternativelly we could have created another context and cancel it after the reporter is done, in a similar fashion to what was done before #11981, but then we would be breaking the chain of derived contexts. (cherry picked from commit d36878a)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…tic#12743) (elastic#12849) After elastic#11981 docker client watching event uses the context provided by the metricset wrapper. This produces a race condition on error reporting: the errors channel will receive a context cancelled error when the context is done, so both paths can be chosen by the select. If the errors one is chosen, an error will be reported and a reconnect will be attempted, that will fail. Alternativelly we could have created another context and cancel it after the reporter is done, in a similar fashion to what was done before elastic#11981, but then we would be breaking the chain of derived contexts. (cherry picked from commit fcedb16)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #11981 docker client watching event uses the context provided by
the metricset wrapper. This produces a race condition on error
reporting: the errors channel will receive a context cancelled error when
the context is done, so both paths can be chosen by the select. If the
errors one is chosen, an error will be reported and a reconnect will be
attempted, that will fail.
Alternativelly we could have created another context and cancel it after
the reporter is done, in a similar fashion to what was done before #11981,
but then we would be breaking the chain of derived contexts.
Fixing it this way at least by now to avoid the flaking errors that this
is causing.