Add timestamp processor #12699
Merged
Add timestamp processor #12699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This processor enables users to set the @timestamp value based on fields in their events. Its configuration is different than the date processors of Logstash and Ingest Node so the name is different to help distinguish them. The date formats are called "layouts" in this processor. The processor is included in the log processing Beats (Filebeat, Journalbeat, and Winlogbeat) only. It bundles the Go 1.12 zoneinfo data with the processor (via the 4d64.com/tz package) in order to allow the processor to work consistently in all environments (see golang/go#21881 more details).
andrewkroh
force-pushed
the
feature/libbeat/timestamp-processor
branch
from
3037806 to
527c308
Compare
|
Pinging @elastic/secops |
adriansr
approved these changes
Jul 2, 2019
| if (p.IgnoreMissing || p.IgnoreFailure) && errors.Cause(err) == common.ErrKeyNotFound { | ||
| return event, nil | ||
| } | ||
| return event, errors.Wrapf(err, "failed to get time field %v", p.Field) |
There was a problem hiding this comment.
This is returning an error when ignore_failure is set but the cause is not a ErrKeyNotFound, is that what you want?
There was a problem hiding this comment.
You're right 👍 , I got the grouping wrong here. It's fixed now.
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
This processor enables users to set the @timestamp value based on fields in their events. Its configuration is different than the date processors of Logstash and Ingest Node so the name is different to help distinguish them. The date formats are called "layouts" in this processor. The processor is included in the log processing Beats (Filebeat, Journalbeat, and Winlogbeat) only. It bundles the Go 1.12 zoneinfo data with the processor (via the 4d64.com/tz package) in order to allow the processor to work consistently in all environments (see golang/go#21881 more details).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This processor enables users to set the
@timestampvalue based on fields in their events. Its configuration is different than the date processors of Logstash and Ingest Node so the name is different to help distinguish them. The date formats are called "layouts" in this processor.The processor is included in the log processing Beats (Filebeat, Journalbeat, and Winlogbeat) only. It bundles the Go 1.12 zoneinfo data with the processor (via the 4d64.com/tz package) in order to allow the processor to work consistently in all environments (see golang/go#21881 more details).