FIX: Sending duplicate log files from journald sometimes. #12479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we get a notification from journald about some change, make sure we still call next(). The return value from next() validates if there is new data. Previously suprious journald change notifications cause the same log line to be sent.
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
kvch
approved these changes
Jun 17, 2019
|
jenkins test this |
|
@mtanski Do you mind adding a changelog entry to Thank you for fixing the problem. |
|
Closing as #12716 solves the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we get a notification from journald about some change, make sure we still
call next(). The return value from next() validates if there is new data.
Previously suprious journald change notifications cause the same log line to
be sent.
This should address this bug:
NicholasPCole/droplet-connectivity-testing#7
https://discuss.elastic.co/t/duplicate-messages-created-by-journalbeat-6-7-1-1/175930