Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove convert_timezone option #12469

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Jun 6, 2019

Apply #12410 to the rest of modules.

Remove references in docs and tests.

Apply elastic#12410 to the rest of modules.
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Add CHANGELOG entry?

@jsoriano
Copy link
Member Author

jsoriano commented Jun 7, 2019

LGTM. Add CHANGELOG entry?

@ycombinator I already added a changelog entry for this in #12410.

@jsoriano
Copy link
Member Author

jsoriano commented Jun 7, 2019

jenkins, test this again please

@jsoriano jsoriano merged commit 9d3653a into elastic:master Jun 11, 2019
@jsoriano jsoriano deleted the filebeat-remove-convert-timezone branch June 11, 2019 10:39
jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 22, 2019
Add documentation about the use of `event.timezone` in modules that do
some kind of timestamp parsing in their pipelines.

Related to elastic#12469
jsoriano added a commit that referenced this pull request Aug 22, 2019
Add documentation about the use of `event.timezone` in modules that do
some kind of timestamp parsing in their pipelines.

Related to #12469
jsoriano added a commit to jsoriano/beats that referenced this pull request Aug 29, 2019
…13313)

Add documentation about the use of `event.timezone` in modules that do
some kind of timestamp parsing in their pipelines.

Related to elastic#12469

(cherry picked from commit 1c95ea5)
jsoriano added a commit that referenced this pull request Aug 30, 2019
…13410)

Add documentation about the use of `event.timezone` in modules that do
some kind of timestamp parsing in their pipelines.

Related to #12469

(cherry picked from commit 1c95ea5)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…13313) (elastic#13410)

Add documentation about the use of `event.timezone` in modules that do
some kind of timestamp parsing in their pipelines.

Related to elastic#12469

(cherry picked from commit e799584)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants