Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metricbeat]Add kubeproxy metrics #12312

Merged
merged 22 commits into from
Jun 26, 2019
Merged

[metricbeat]Add kubeproxy metrics #12312

merged 22 commits into from
Jun 26, 2019

Conversation

odacremolbap
Copy link
Contributor

@odacremolbap odacremolbap commented May 28, 2019 •
edited
Loading

Related issue: #10431

Import kubeproxy prometheus metrics to kubernetes module at metricbeat

@odacremolbap odacremolbap requested review from a team as code owners May 28, 2019 11:54
@odacremolbap odacremolbap added Team:Integrations Label for the Integrations team containers Related to containers use case in progress Pull request is currently in progress. Metricbeat Metricbeat labels May 28, 2019
@odacremolbap odacremolbap added review and removed in progress Pull request is currently in progress. labels Jun 1, 2019
exekias
exekias reviewed Jun 3, 2019
View reviewed changes
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, all minor

@odacremolbap
Copy link
Contributor Author

jenkins, test this

exekias
exekias approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with merging this as long as we can change the layout later depending on #12446 outcome

deploy/kubernetes/metricbeat/metricbeat-daemonset-configmap.yaml
@@ -83,3 +83,9 @@ data:
#bearer_token_file: /var/run/secrets/kubernetes.io/serviceaccount/token
#ssl.certificate_authorities:
#- /var/run/secrets/kubernetes.io/serviceaccount/service-ca.crt
- module: kubernetes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: a new line before this would improve readability

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like beats yaml generation is removing any \n in there

@odacremolbap odacremolbap merged commit f3924be into elastic:master Jun 26, 2019
@odacremolbap odacremolbap deleted the task/kube-proxy-module branch June 27, 2019 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias approved these changes

Assignees

@odacremolbap odacremolbap

Labels
containers Related to containers use case Metricbeat Metricbeat review Team:Integrations Label for the Integrations team v7.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odacremolbap @exekias @andresrc