Skipping unparsable lines in docker input #12268

marqc · 2019-05-24T11:03:51Z

fix proposal for problem referenced in https://discuss.elastic.co/t/input-docker-stuck-when-bad-offset-is-saved-in-registry-file-bug/181828 where docker input is unparsable (either input itself is corrupted, or offset in registry is corrupted)

elasticmachine · 2019-05-24T11:03:52Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

libbeat/reader/reader.go

kvch · 2019-05-27T07:15:31Z

jenkins test this

kvch · 2019-05-27T07:19:13Z

filebeat/input/log/harvester.go

@@ -276,6 +276,10 @@ func (h *Harvester) Run() error {
 				logp.Info("End of file reached: %s. Closing because close_eof is enabled.", h.state.Source)
 			case ErrInactive:
 				logp.Info("File is inactive: %s. Closing because close_inactive of %v reached.", h.state.Source, h.config.CloseInactive)
+			case reader.ErrLineUnparsable:
+				logp.Err("Skipping unparsable line in file: %v", h.state.Source)


Nit: I think this log message should be Info, as we have already emitted an error message from DockerJSON with the error message. To me this is rather a notification telling the user that a line was skipped due to an error before.

I changed it to info

I think you have changed the wrong line for the case default.

this time, I changed what i was supposed to change ;)

libbeat/reader/reader.go

exekias · 2019-05-27T10:10:43Z

Thank you for opening, this is defensive code that should help when this problems arises. Could you add an entry in CHANGELOG.next.asciidoc?

exekias · 2019-05-27T10:12:39Z

would love to see some unit tests in docker_json_test.go

marqc · 2019-05-27T13:47:26Z

@exekias changelog entry added, unit tests for docker_json changed to cover error message verification

exekias · 2019-05-27T13:52:23Z

jenkins, test this please

(cherry picked from commit 3451d06)

adawalli · 2019-06-20T17:34:51Z

Will this be backported to 6.x? Really hitting this with a bunch of our containers

…12608) * Skipping unparsable lines in docker input (#12268) (cherry picked from commit 3451d06)

(cherry picked from commit 3451d06)

exekias · 2019-07-08T11:20:01Z

I've opened a backport to 6.8 branch: #12813

…12813) * Skipping unparsable lines in docker input (#12268) (cherry picked from commit 3451d06)

detro · 2019-07-16T14:50:14Z

Hello.
I have a question about this fix: why is it tagged with 7.2.0 but it seems like it will be out only in 7.2.1? Was this just a hickup or am I misunderstanding the meaning of the tag?

Regardless, thanks for this: looking forward to update Filebeat and get rid of this issue. We have had long running containers that logged nothing for the last 4 days because of the issue that this code fixes.

detro · 2019-07-22T16:26:07Z

Hello. Any update about the release of the 7.2.1 Docker image?
Alternatively, can I ask for a pointer (a doc?) so I can build and package a Docker image with Filebeat 7.2.1?

Thanks in advance :)

… input (elastic#12608) * Skipping unparsable lines in docker input (elastic#12268) (cherry picked from commit 0cc16fd)

marqc requested a review from a team as a code owner May 24, 2019 11:03

houndci-bot reviewed May 24, 2019

View reviewed changes

libbeat/reader/reader.go Show resolved Hide resolved

ph assigned exekias May 24, 2019

ph added Filebeat Filebeat review labels May 24, 2019

kvch reviewed May 27, 2019

View reviewed changes

kvch approved these changes May 27, 2019

View reviewed changes

marqc force-pushed the docker_input_skip_unparsable_lines branch from cbaafbf to eda4a25 Compare May 27, 2019 08:04

houndci-bot reviewed May 27, 2019

View reviewed changes

libbeat/reader/reader.go Outdated Show resolved Hide resolved

marqc force-pushed the docker_input_skip_unparsable_lines branch 2 times, most recently from 7789894 to 5c3ab65 Compare May 27, 2019 08:56

Skipping unparsable lines in docker input

281f5b9

marqc force-pushed the docker_input_skip_unparsable_lines branch from 5c3ab65 to 281f5b9 Compare May 27, 2019 13:46

exekias added bug needs_backport PR is waiting to be backported to other branches. labels May 27, 2019

exekias approved these changes May 27, 2019

View reviewed changes

exekias merged commit 3451d06 into elastic:master May 27, 2019

This was referenced Jun 19, 2019

Filebeat autodiscovery close after docker events restart #12558

Closed

Cherry-pick #12268 to 7.2: Skipping unparsable lines in docker input #12608

Merged

exekias added v7.2.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jun 19, 2019

exekias pushed a commit to exekias/beats that referenced this pull request Jun 19, 2019

Skipping unparsable lines in docker input (elastic#12268)

101a641

(cherry picked from commit 3451d06)

exekias pushed a commit that referenced this pull request Jul 8, 2019

Cherry-pick #12268 to 7.2: Skipping unparsable lines in docker input (#…

2a43b3e

…12608) * Skipping unparsable lines in docker input (#12268) (cherry picked from commit 3451d06)

exekias mentioned this pull request Jul 8, 2019

Cherry-pick #12268 to 6.8: Skipping unparsable lines in docker input #12813

Merged

exekias pushed a commit to exekias/beats that referenced this pull request Jul 8, 2019

Skipping unparsable lines in docker input (elastic#12268)

f650f0b

(cherry picked from commit 3451d06)

exekias added the v6.8.2 label Jul 8, 2019

exekias pushed a commit that referenced this pull request Jul 11, 2019

Cherry-pick #12268 to 6.8: Skipping unparsable lines in docker input (#…

13b1738

…12813) * Skipping unparsable lines in docker input (#12268) (cherry picked from commit 3451d06)

detro mentioned this pull request Jul 16, 2019

Periodic system/process metricset crashes under Windows #12826

Closed

ChrsMark mentioned this pull request Nov 20, 2020

Properly update offset in case of unparasable line #22685

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skipping unparsable lines in docker input #12268

Skipping unparsable lines in docker input #12268

marqc commented May 24, 2019

elasticmachine commented May 24, 2019

kvch commented May 27, 2019

kvch May 27, 2019

marqc May 27, 2019

kvch May 27, 2019

marqc May 27, 2019

exekias commented May 27, 2019

exekias commented May 27, 2019

marqc commented May 27, 2019

exekias commented May 27, 2019

adawalli commented Jun 20, 2019

exekias commented Jul 8, 2019

detro commented Jul 16, 2019

detro commented Jul 22, 2019 •

edited

Loading

Skipping unparsable lines in docker input #12268

Skipping unparsable lines in docker input #12268

Conversation

marqc commented May 24, 2019

elasticmachine commented May 24, 2019

kvch commented May 27, 2019

kvch May 27, 2019

Choose a reason for hiding this comment

marqc May 27, 2019

Choose a reason for hiding this comment

kvch May 27, 2019

Choose a reason for hiding this comment

marqc May 27, 2019

Choose a reason for hiding this comment

exekias commented May 27, 2019

exekias commented May 27, 2019

marqc commented May 27, 2019

exekias commented May 27, 2019

adawalli commented Jun 20, 2019

exekias commented Jul 8, 2019

detro commented Jul 16, 2019

detro commented Jul 22, 2019 • edited Loading

detro commented Jul 22, 2019 •

edited

Loading