[Auditbeat] Host: Fill top-level host fields #12259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/secops |
|
Test failure will be fixed by #12261. |
andrewkroh
approved these changes
May 24, 2019
| RootFields: common.MapStr{ | ||
| "event": common.MapStr{ | ||
| "kind": eventType, | ||
| "action": action.String(), | ||
| }, | ||
| "message": hostMessage(host, action), | ||
| }, | ||
| MetricSetFields: host.toMapStr(), | ||
| } | ||
| MetricSetFields: hostFields, |
There was a problem hiding this comment.
If it weren't a breaking change I'd suggest not duplicating values between host.* and system.host.*.
cwurm
pushed a commit
to cwurm/beats
that referenced
this pull request
May 28, 2019
Copy fields of `system/host` dataset to `host.*` so those are always filled. Also add `system.audit.host.os.codename` to complete what `add_host_metadata` adds. (cherry picked from commit 5502f4e)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…st fields (elastic#12316) Copy fields of `system/host` dataset to `host.*` so those are always filled. Also add `system.audit.host.os.codename` to complete what `add_host_metadata` adds. (cherry picked from commit f6cebc1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, the Auditbeat
system/hostdataset puts all its fields undersystem.audit.host.*, making its output hard to use together with the data usually added by theadd_host_metadataprocessor in the top-levelhostobject.With this PR, the dataset copies its fields to
host.*so those are always filled.Most importantly,
add_host_metadatadoes not fillhost.ipandhost.macby default. They will now always be filled by this dataset.I also added
system.audit.host.os.codenameto complete what the processor adds.