Cherry-pick #12168 to 6.8: [Auditbeat] Fix issues with multiple calls to rpmReadConfigFiles #12188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stic#12168) This patch fixes two issues in Auditbeat's system/package on RPM distros: - Multiple calls to rpmReadConfigFiles lead to a crash (segmentation fault). It is necessary to call rpmFreeRpmrc after each call to rpmReadConfigFiles. See [1] for a similar issue. - In addition, it is also necessary to call rpmFreeMacros (when available) to avoid leaking memory after each rpmReadConfigFiles call. 1: https://lists.fedorahosted.org/pipermail/anaconda-patches/2015-February/015826.html Fixes elastic#12147 (cherry picked from commit a1a7d7e)
andrewkroh
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #12168 to 6.8 branch. Original message:
This patch fixes two issues in Auditbeat's system/package on RPM
distros:
Multiple calls to rpmReadConfigFiles lead to a crash (segmentation
fault). It is necessary to call rpmFreeRpmrc after each call to
rpmReadConfigFiles.
See [1] for a similar issue.
In addition, it is also necessary to call rpmFreeMacros (when
available) to avoid leaking memory after each
rpmReadConfigFiles call.
1: https://lists.fedorahosted.org/pipermail/anaconda-patches/2015-February/015826.html
Fixes #12147
(cherry picked from commit a1a7d7e)