Remove count field from the Packetbeat event #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monicasarbu
force-pushed
the
remove_count_field_packetbeat
branch
from
c05e0a7
to
482f511
Compare
|
LGTM |
|
@monicasarbu Seems like you missed some count checks in the packetbeat tests (see travis build). |
monicasarbu
force-pushed
the
remove_count_field_packetbeat
branch
from
59f1642
to
c242cdb
Compare
|
LGTM After we complete the remove of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar with the other Beats, removing the count field from the Packetbeat event.
This change requires an update of the Packetbeat dashboards as they rely on count.