Fix flaky service_integration_windows_test #11662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narph
added
Team:Integrations
andrewkroh
requested changes
Apr 5, 2019
metricbeat/module/windows/service/service_integration_windows_test.go
Outdated
Show resolved
Hide resolved
|
jenkins, test this |
ruflin
approved these changes
Apr 8, 2019
andrewkroh
approved these changes
Apr 8, 2019
narph
force-pushed
the
fix-service-integration-windows-test
branch
from
911fc0a to
87b5d0c
Compare
|
jenkins, test this |
Some services can change state before reader.Read() call is executed which will result in a test faillure. Fix test by introducing a confidence factor and enriching the error message with the state-changed service details. Fixes elastic#8880 and elastic#7977
…test.go Co-Authored-By: narph <mariana@elastic.co>
narph
force-pushed
the
fix-service-integration-windows-test
branch
from
87b5d0c to
2abafae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some services can change state before reader.Read() call is executed which will result in a test faillure.
Fix test by introducing a confidence factor and enriching the error message with the state-changed service details.
Fixes #8880 and #7977