Re-introduce field formats on ECS fields. #11240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmat
added
ecs
needs_backport
|
Since this reintroduces field formats exactly as they were before #11150, I don't think this requires a changelog. |
|
Error seems unrelated, in Metricbeat test suite:
|
|
jenkins, test this |
simitt
reviewed
Mar 14, 2019
| @@ -1807,6 +1813,7 @@ | |||
| - name: bytes | |||
| level: core | |||
| type: long | |||
| format: bytes | |||
| description: Bytes sent from the source to the destination. | |||
| example: 184 | |||
| - name: domain | |||
There was a problem hiding this comment.
Looks like you missed:
There was a problem hiding this comment.
Thanks, you're right. I'll go add them
🏃
added 2 commits
March 14, 2019 09:59
They were accidentally removed by elastic#11150.
webmat
force-pushed
the
re-add-ecs-formats
branch
from
0528af5
to
a5e87ec
Compare
|
Rebased on top of master. I think #11230 fixes the Metricbeat test flakiness |
webmat
added a commit
to webmat/beats
that referenced
this pull request
Mar 14, 2019
They were accidentally removed by elastic#11150.
webmat
added a commit
that referenced
this pull request
Mar 14, 2019
webmat
referenced
this pull request
Mar 22, 2019
Moved the definition of `agent.hostname` to fields.common.yml
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
They were accidentally removed by elastic#11150.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were accidentally removed by #11150.