Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system test for libbeat internal x-pack monitoring #10645

Merged
merged 11 commits into from
Feb 11, 2019
Merged

Add system test for libbeat internal x-pack monitoring #10645

merged 11 commits into from
Feb 11, 2019

Conversation

ycombinator
Copy link
Contributor

libbeat has code for shipping x-pack monitoring data to the elasticsearch cluster configured either via outputs.elasticsearch.* or xpack.monitoring.elasticsearch.*. This cluster then exports the given data to a monitoring cluster, which may be a separate dedicated monitoring cluster or the same cluster that received the data from the beat.

Currently there are no system tests to test this x-pack monitoring feature in libbeat. This PR creates such a system test. The test:

  1. configures the test beat (mockbeat) to ship data to a cluster defined via
    xpack.monitoring.elasticsearch.hosts. Let's call this cluster ES1.
  2. sets up a dedicated monitoring cluster. Let's call this cluster ES2.
  3. defines an HTTP exporter in ES1's cluster settings to export monitoring data it receives to ES2.
  4. enables monitoring collection in ES1.
  5. starts up mockbeat and waits till it has shipped some monitoring data to ES1.
  6. queries ES2 and asserts that the expected data was indexed into .monitoring-beats-* indices.

@ycombinator ycombinator added in progress Pull request is currently in progress. libbeat flaky-test Unstable or unreliable test cases. v7.2.0 labels Feb 7, 2019
@ycombinator ycombinator requested a review from a team as a code owner February 7, 2019 23:20
@ycombinator ycombinator added :Testing and removed flaky-test Unstable or unreliable test cases. labels Feb 7, 2019
@ycombinator ycombinator changed the title [WIP] Add system test for libbeat internal x-pack monitoring Add system test for libbeat internal x-pack monitoring Feb 8, 2019
@ycombinator ycombinator added review and removed in progress Pull request is currently in progress. labels Feb 8, 2019
@ycombinator ycombinator requested review from ruflin and urso February 8, 2019 00:09
@ycombinator
Copy link
Contributor Author

jenkins, test this

@ycombinator
Copy link
Contributor Author

ycombinator commented Feb 9, 2019

Not sure why the CLA check isn't passing, but if you're okay with that 😄 [EDIT: CLA check has passed now], this PR is ready for your review, @urso and @ruflin. Thank you!

Please note that this PR just adds a test for existing functionality. I plan to then build upon this test for the functionality being introduced in #9260.

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Comment can be addressed later.

libbeat/tests/system/config/mockbeat.yml.j2 Show resolved Hide resolved
@ycombinator ycombinator merged commit 6665d1a into elastic:master Feb 11, 2019
@ycombinator ycombinator deleted the libbeat-monitoring-system-test branch February 11, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants