Clean up Kibana, remove Elasticsearch loading and 5.x version #10451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 5.x the dashboards were loaded through Elasticsearch and not Kibana. For 6.x and 7.x dashboards are loaded through the Kibana API. The old code is removed in this PR. Also some code is cleaned up around talking to 5.x Kibana APIs.
ruflin
added
review
refactoring
:Dashboards
Team:Integrations
houndci-bot
reviewed
Jan 31, 2019
|
The goal of this code is to make the implementation of #10450 easier / cleaner. |
|
CI failure in Journalbeat is related to not being able to push a docker image but not related to this PR. |
jsoriano
approved these changes
Jan 31, 2019
| func ImportDashboards( | ||
| ctx context.Context, | ||
| beatName, hostname, homePath string, | ||
| kibanaConfig, esConfig, dashboardsConfig *common.Config, | ||
| kibanaConfig, dashboardsConfig *common.Config, | ||
| msgOutputter MessageOutputter, | ||
| ) error { |
There was a problem hiding this comment.
Does it need an entry in the developers changelog?
There was a problem hiding this comment.
yes, will add one in my follow up PR.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 5.x the dashboards were loaded through Elasticsearch and not Kibana. For 6.x and 7.x dashboards are loaded through the Kibana API. The old code is removed in this PR.
Also some code is cleaned up around talking to 5.x Kibana APIs.